New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: lando quality improvements #129

Merged

finnlewis merged 1 commit into 3.x from feature/3.x/lando-improvements

Oct 2, 2023

Member

millnut commented Sep 23, 2023

I've added some small DX improvements for lando which make it more stable/predictable when using Xdebug;

Xdebug tweaks to work out of the box all the time once xdebug-on is run (both cli and non-cli)
Add lando to the vscode settings file
Update node to version 18 to match Drupal 10.1 requirements
Use the lando environment settings so we don't hardcode username/password/host, etc.. in settings files and it instead uses the values set in the .lando.dist.yml file


          refactor: lando quality improvements

002b076

millnut requested a review from stephen-cox

September 23, 2023 08:30

finnlewis self-requested a review

September 25, 2023 13:47

millnut mentioned this pull request

refactor: lando quality improvements localgovdrupal/localgov_microsites_project#34

Merged

stephen-cox approved these changes

View reviewed changes

Member

stephen-cox left a comment

Working nicely and includes some good tips on Lando usage I can use in other projects 😃

finnlewis merged commit 12875ef into 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet