Skip to content

Commit

Permalink
Merge branch '3.x' into feature/3.x/142/fix_non_standard_bin_dir
Browse files Browse the repository at this point in the history
  • Loading branch information
finnlewis committed Apr 4, 2024
2 parents d2a06d1 + 97f2fa3 commit ff5f29c
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .ddev/config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: localgov
type: drupal9
type: drupal10
docroot: web
php_version: "8.1"
webserver_type: nginx-fpm
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
php-version:
- '8.1'
- '8.2'
- '8.3'

steps:

Expand Down Expand Up @@ -99,6 +100,7 @@ jobs:
php-version:
- '8.1'
- '8.2'
- '8.3'

steps:

Expand Down Expand Up @@ -135,6 +137,7 @@ jobs:
php-version:
- '8.1'
- '8.2'
- '8.3'

steps:

Expand Down Expand Up @@ -170,6 +173,7 @@ jobs:
php-version:
- '8.1'
- '8.2'
- '8.3'

steps:

Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,7 @@
.ddev/homeadditions/
.ddev/providers/
.ddev/xhprof/

# Ignore macOS DS_Store files
.DS_Store
**/.DS_Store
5 changes: 5 additions & 0 deletions .lando.dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ proxy:
- 'solr-sitewide.localgov.lndo.site:8983'
services:
appserver:
scanner:
retry: 5
xdebug: true
build_as_root:
# This disables Xdebug during build, but puts all dependencies in place
Expand Down Expand Up @@ -71,6 +73,9 @@ services:
config:
dir: .lando/solr/localgov_sitewide_solr
tooling:
composer:
service: appserver
cmd: /usr/local/bin/composer
deprecated:
service: appserver
cmd: 'bash -c "/app/vendor/bin/phpstan analyse -c /app/phpstan.neon /app/web/profiles/contrib/localgov* /app/web/modules/contrib/localgov* /app/web/themes/contrib/localgov*"'
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,15 @@ This project template should provide a kickstart for managing your site dependen

For guidance on installing see:

- [Installing LocalGov Drupal locally with composer](https://github.com/localgovdrupal/localgov/blob/2.x/README.md#installing-localgov-drupal-locally-with-composer)
- [Installing LocalGov Drupal locally with composer](https://github.com/localgovdrupal/localgov#installing-localgov-drupal-locally-with-composer)
- [Getting started on LocalGov Drupal docs](https://docs.localgovdrupal.org/devs/getting-started/)

## composer.json and composer.lock

We expect most projects using this package will start with the composer.json in this package, committing it to your own project repository as your own root composer.json. You can then extend composer.json, requiring other Drupal and composer packages and evolve your codebase as needed.

Once you have run a `composer create-project` command, it is usually desirable to commit the composer.lock file to your project repository and use this lock file to control the specific version of packages that you deploy to dev, test and ultimately production hosting environments.

## Gitpod

Gitpod allows you to run a virtual development environment in the cloud in your browser.
Expand Down
2 changes: 1 addition & 1 deletion assets/composer/settings.lando.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* @see https://wiki.php.net/rfc/expectations
*/
assert_options(ASSERT_ACTIVE, TRUE);
\Drupal\Component\Assertion\Handle::register();
assert_options(ASSERT_EXCEPTION, TRUE);

/**
* Enable local development services.
Expand Down
5 changes: 4 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"cweagans/composer-patches": "^1.6",
"drupal/core-composer-scaffold": "^10.0",
"drupal/core-recommended": "^10.0",
"localgovdrupal/localgov": "^3.0@alpha",
"localgovdrupal/localgov": "^3.0",
"localgovdrupal/localgov_search_solr": "^1.1"
},
"require-dev": {
Expand Down Expand Up @@ -47,6 +47,9 @@
},
"extra": {
"enable-patching": true,
"patchLevel": {
"drupal/core": "-p2"
},
"drupal-scaffold": {
"locations": {
"web-root": "web/"
Expand Down
6 changes: 5 additions & 1 deletion phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@
<description>PHP CodeSniffer configuration for LocalGovDrupal.</description>

<arg name="extensions" value="inc,install,module,php,profile,test,theme,yml"/>
<config name="drupal_core_version" value="9"/>
<config name="drupal_core_version" value="10"/>

<file>web/modules/contrib/</file>
<file>web/profiles/contrib/localgov/</file>
<file>web/themes/contrib/</file>

<!-- Exclude 3rd party code -->
<exclude-pattern>web\/modules\/contrib\/(?!localgov_.*)</exclude-pattern>
<exclude-pattern>web\/themes\/contrib\/(?!localgov_.*)</exclude-pattern>

<rule ref="./vendor/drupal/coder/coder_sniffer/Drupal"/>
<rule ref="./vendor/drupal/coder/coder_sniffer/DrupalPractice"/>

Expand Down

0 comments on commit ff5f29c

Please sign in to comment.