fix: refactor test so it works with Drupal 10.3 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekes
approved these changes
Sep 3, 2024
| 'mail' => 'admin@example.net', | ||
| ]); | ||
| $admin_user->addRole('administrator'); | ||
| $admin_user = $this->createUser([], 'admin', TRUE, ['mail' => 'admin@example.net']); |
Member
There was a problem hiding this comment.
Is EntityKernelTestBase just here for this?
Interested rather than bothered.
Member
Author
There was a problem hiding this comment.
Yes and I believe some other things it does differently, trying the other testbase didn't seem to work with assigning roles correctly (at least in Drupal 10.3) until I did some digging around other contrib modules that seem to make similar changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This fixes #40 the failing test in this module, and the last failing PHPUnit test for the project repo 🎉