Skip to content

Conversation

@ekes
Copy link
Member

@ekes ekes commented May 7, 2024

Copy link
Contributor

@antonio93rs antonio93rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on previous conversations from #155 (comment) this all look good to me now.

@finnlewis
Copy link
Member

Tested this locally, following steps on #154 and it works a treat!

Thank you @antonio93rs and @ekes !

@ekes
Copy link
Member Author

ekes commented May 7, 2024

I this case I propose we don't squash merge to maintain the individual commits for different purposes that have good commit messages :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide title block and Guide Navigation links are not respecting translations

4 participants