-
Notifications
You must be signed in to change notification settings - Fork 1
Release 1.1.2 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.1.2 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a plugin for Drupal's Geocoder module. Useful for address lookup. The actual PHP Geocoder for the OS Places API is provided by the localgovdrupal/localgov_os_places_geocoder_provider package. This plugin is a Drupal specific wrapper over the OS Places PHP Geocoder. API details: https://osdatahub.os.uk/docs/places/overview
Drupal schema definition for our OS Places Drupal plugin configuration.
Non-admin users with the "Access geo overview page" permission are unable to access the Geo overview page at the moment. Here we resolve it by assigning this permission as the admin_permission for Geo entities.
Updated the PHP Geocoder class name to match the latest.
Added a Functional test. Also fixed deprecation errors.
Fix: Access to Geo overview page
Adding basic description and pitfalls of using the OS Places geocoder plugin.
…-plugin Ordnance Survey Places geocoder plugin
Member
|
Meh #45 |
…avor of extension listing services
Rather than alter __construct api adds to injection ::create(). Could even use getters and setters for $this->renderer, but think it's plenty.
Fix/45 drupal93 deprication
Member
|
Merging this as all tests are passing apart from the deprecated code checks on other modules. |
Contributor
|
Thanks Finn :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits on Oct 11, 2021
Merge branch '1.x' into release-1.x
@ekes
ekes committed on 11 Oct
Commits on Oct 19, 2021
Ordnance Survey Places Geocoder plugin.
@Adnan-cds
Adnan-cds committed on 19 Oct
Ordnance Survey Places Geocoder plugin.
@Adnan-cds
Adnan-cds committed on 19 Oct
Commits on Nov 25, 2021
Fix: Access to Geo overview page.
@Adnan-cds
Adnan-cds committed 18 days ago
Commits on Nov 30, 2021
Fix: Ordnance Survey Places Geocoder plugin
@Adnan-cds
Adnan-cds committed 13 days ago
Commits on Dec 1, 2021
Fix: Access to Geo overview page.
@Adnan-cds
Adnan-cds committed 12 days ago
Commits on Dec 6, 2021
Add an access denied test for the list admin page.
@ekes
ekes committed 7 days ago
Merge pull request #43 from localgovdrupal/fix/overview-page-perm
@Adnan-cds
Adnan-cds committed 7 days ago
Commits on Dec 7, 2021
Feature(doc): OS Places geocoder plugin.
@Adnan-cds
Adnan-cds committed 6 days ago
Commits on Dec 13, 2021
Merge pull request #41 from localgovdrupal/feature/os-places-geocoder…
@andybroomfield
andybroomfield committed 33 seconds ago