Skip to content

Conversation

@andybroomfield
Copy link
Contributor

Commits on Oct 11, 2021
Merge branch '1.x' into release-1.x

@ekes
ekes committed on 11 Oct

Commits on Oct 19, 2021
Ordnance Survey Places Geocoder plugin.

@Adnan-cds
Adnan-cds committed on 19 Oct

Ordnance Survey Places Geocoder plugin.

@Adnan-cds
Adnan-cds committed on 19 Oct

Commits on Nov 25, 2021
Fix: Access to Geo overview page.

@Adnan-cds
Adnan-cds committed 18 days ago

Commits on Nov 30, 2021
Fix: Ordnance Survey Places Geocoder plugin

@Adnan-cds
Adnan-cds committed 13 days ago

Commits on Dec 1, 2021
Fix: Access to Geo overview page.

@Adnan-cds
Adnan-cds committed 12 days ago

Commits on Dec 6, 2021
Add an access denied test for the list admin page.

@ekes
ekes committed 7 days ago

Merge pull request #43 from localgovdrupal/fix/overview-page-perm

@Adnan-cds
Adnan-cds committed 7 days ago

Commits on Dec 7, 2021
Feature(doc): OS Places geocoder plugin.

@Adnan-cds
Adnan-cds committed 6 days ago

Commits on Dec 13, 2021
Merge pull request #41 from localgovdrupal/feature/os-places-geocoder…

@andybroomfield
andybroomfield committed 33 seconds ago

ekes and others added 10 commits October 11, 2021 15:32
This is a plugin for Drupal's Geocoder module.  Useful for address lookup.

The actual PHP Geocoder for the OS Places API is provided by the
localgovdrupal/localgov_os_places_geocoder_provider package.  This plugin is a
Drupal specific wrapper over the OS Places PHP Geocoder.

API details: https://osdatahub.os.uk/docs/places/overview
Drupal schema definition for our OS Places Drupal plugin configuration.
Non-admin users with the "Access geo overview page" permission are unable to
access the Geo overview page at the moment.  Here we resolve it by assigning
this permission as the admin_permission for Geo entities.
Updated the PHP Geocoder class name to match the latest.
Added a Functional test.  Also fixed deprecation errors.
Adding basic description and pitfalls of using the OS Places geocoder plugin.
…-plugin

Ordnance Survey Places geocoder plugin
@andybroomfield andybroomfield requested a review from ekes December 13, 2021 14:11
@ekes
Copy link
Member

ekes commented Dec 13, 2021

Meh #45

ekes and others added 3 commits December 13, 2021 16:05
Rather than alter __construct api adds to injection ::create().
Could even use getters and setters for $this->renderer, but think it's
plenty.
@finnlewis
Copy link
Member

Merging this as all tests are passing apart from the deprecated code checks on other modules.

@finnlewis finnlewis merged commit 70c56ee into release-1.x Dec 15, 2021
@Adnan-cds
Copy link
Contributor

Thanks Finn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants