fix: static analysis errors #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adnan-cds
reviewed
Aug 28, 2024
Contributor
Adnan-cds
left a comment
Adnan-cds
left a comment
There was a problem hiding this comment.
Hi Lee,
Thanks for looking into this. I have finally managed to configure phpstan to highlight these errors :) Your fixes look okay. I have proposed a slightly different fix in one of the files after examining the relevant code. Let me know what you think.
Adnan-cds
approved these changes
Aug 29, 2024
Contributor
Adnan-cds
left a comment
Adnan-cds
left a comment
There was a problem hiding this comment.
Thank you Lee. All good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes (#87) errors reported by the static analysis check