Fix: Address lookup caching #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly added local custodian code restriction should also be considered when opting to use cached results from previous address lookups. This is particularly useful when there are multiple address lookup elements in a form but they are using different local custodian codes.
andybroomfield
approved these changes
Oct 21, 2024
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Looks good to me @Adnan-cds.
Usual caveat in that I have to switch to Olivero to test because the address lookup does not function in localgov_base.
Contributor
Author
|
Thanks Andy. Merging...
That's right. Until this is resolved, the address lookup remains broken in localgov_base. I hope Mark or Maria will get a chance to resolve this. @markconroy @msayoung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added local custodian code restriction should also be considered when opting to use cached results from previous address lookups. This is particularly useful when there are multiple address lookup elements in a form but they are using different local custodian codes.
Test steps
Local authoritydropdown.