Skip to content

Conversation

@Adnan-cds
Copy link
Contributor

@Adnan-cds Adnan-cds commented Jan 25, 2024

We want to display the title of the Address lookup element by default. At the moment, the relevant configuration chooses "Invisible" title display by default.

Closes #64

Test steps

  • Add an Address lookup element to a form. Leave the "Form display > Title display" setting untouched.
  • View the form.
  • The title of the Address lookup element should appear on the form.

We want to display the title of the Address lookup element by default.  At the
moment, the relevant configuration chooses "Invisible" title display by default.
@Adnan-cds Adnan-cds changed the title Feature: Display title by default Feature: Display Adddress lookup element title by default Jan 25, 2024
@Adnan-cds Adnan-cds marked this pull request as draft January 25, 2024 14:33
@Adnan-cds Adnan-cds marked this pull request as ready for review January 25, 2024 15:36
@finnlewis finnlewis self-assigned this Feb 6, 2024
@finnlewis
Copy link
Member

Works for me @Adnan-cds !

Before:

image

After:

image

Happy to approve on that basis.

Do you want @andybroomfield to confirm too or happy to merge?

@Adnan-cds
Copy link
Contributor Author

Do you want @andybroomfield to confirm too or happy to merge?

Screenshot you have added above looks good. Thanks a lot. I will merge tomorrow in case Andy wants to check.

@andybroomfield
Copy link
Contributor

@Adnan-cds Looks good on visual inspection so if you want to merge that good.

@Adnan-cds
Copy link
Contributor Author

Thanks Andy. Thanks Finn. Merging...

@Adnan-cds Adnan-cds merged commit 1fd9c5b into 1.x Feb 20, 2024
@finnlewis finnlewis removed their assignment Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Display the Title of the Address lookup element by default

4 participants