-
Notifications
You must be signed in to change notification settings - Fork 2
Added Drupal 10 support #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One cause of the failing tests appears to be that jQuery once() is gone from Drupal 10. https://www.drupal.org/forum/support/upgrading-drupal/2023-06-21/jquery-once-in-drupal-10 I made a start at trying to fix that, but I'm no JS expert and I'm not sure if the address lookup was working for me in the first place! @Adnan-cds should the address lookup work out of the box for me on a D9 install? |
Yeah, it should work. Otherwise the Drupal 9 test wouldn't have passed.
I am working on this on a different module. I can take a look at this later if you want. |
|
|
||
| // Behaviors to only attach once. | ||
| $('.js-centralhub-address-lookup', context).once('central-hub-behaviours').each(function () { | ||
| $(once('central-hub-behaviours', '.js-centralhub-address-lookup', context)).each(function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting :)
Adnan-cds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing, so why not :)
Fixes #42