Skip to content

Conversation

@stephen-cox
Copy link
Member

Fixes #42

@finnlewis
Copy link
Member

One cause of the failing tests appears to be that jQuery once() is gone from Drupal 10.

https://www.drupal.org/forum/support/upgrading-drupal/2023-06-21/jquery-once-in-drupal-10

I made a start at trying to fix that, but I'm no JS expert and I'm not sure if the address lookup was working for me in the first place!

@Adnan-cds should the address lookup work out of the box for me on a D9 install?

@Adnan-cds
Copy link
Contributor

should the address lookup work out of the box for me on a D9 install?

Yeah, it should work. Otherwise the Drupal 9 test wouldn't have passed.

One cause of the failing tests appears to be that jQuery once() is gone from Drupal 10.

I am working on this on a different module. I can take a look at this later if you want.

@stephen-cox stephen-cox mentioned this pull request Sep 22, 2023
@stephen-cox stephen-cox marked this pull request as ready for review September 22, 2023 16:05

// Behaviors to only attach once.
$('.js-centralhub-address-lookup', context).once('central-hub-behaviours').each(function () {
$(once('central-hub-behaviours', '.js-centralhub-address-lookup', context)).each(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting :)

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, so why not :)

@finnlewis finnlewis merged commit dd559a3 into 1.x Sep 23, 2023
@stephen-cox stephen-cox deleted the feature/1.x/42-drupal-10 branch September 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drupal 10 support

5 participants