Fix eslint issues #173
Fix eslint issues #173
Conversation
|
@markconroy the tests aren't running on this pull request. Just wondering how best to bring this together with #171 Merge the Drupal 11 branch into this one to run all the tests together? Merge this branch into the Drupal 11 branch? https://github.com/localgovdrupal/localgov_elections/tree/feature/2.x/159-drupal-11-support @stephen-cox @tonypaulbarker any thoughts? |
|
@finnlewis these changes look quite significant so I think let's keep them apart until at least reviewed and validated locally so we don't block one or the other from progressing if any changes are needed. Can we bring the tests file into this one? |
|
@finnlewis We need to merge #170 and #171 (although the latter includes the former). We can then merge 2.x into this PR and the tests will run. |
|
@markconroy ESLint javascript checks flagged up some errors and warnings. |
|
Getting close, still 8 errors! |
|
@markconroy thinks he'll be able to address the remaining issues soon. |
|
@finnlewis @tonypaulbarker All checks have passed. Ready for testing again. |
tonypaulbarker
left a comment
tonypaulbarker
left a comment
There was a problem hiding this comment.
Looks good to me.
Functional testing against the demo content looks sound.
No concole errors to report.
Appears to be no functional changes.
Nice naming conventions.
Closes #165
What does this change?
Rewrites/reformats our JS to follow Drupal coding standards.