Fix NULL $extender breaks PageHeaderBlock #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
//cc @NikLP |
ekes
approved these changes
Feb 18, 2025
Member
ekes
left a comment
ekes
left a comment
There was a problem hiding this comment.
As discussed in slack. Correct that it returns NULL if not existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #270.
Since the PageHeaderDisplay extender can be disabled, support cases when it is not enabled.
What does this change?
How to test
Under /admin/structure/views/settings/advanced turn off Page header display extender.
Then load a views page (or create a new page view).
Should no longer WSOD.
How can we measure success?
Less WSOD reports
Have we considered potential risks?
Fallback is to NULL so restores previous behaviour.
Images
n/a
Accessibility
n/a