Skip to content

Feature/820 coding standards #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finnlewis merged 2 commits into from
Jul 15, 2025
Merged

Feature/820 coding standards #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613f9ea
Coding standards fixes
markconroy Jul 15, 2025
f12fd7b
Coding standards fixes
markconroy Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/base/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ img {
img[alt] {
text-wrap: balance;
font-size: var(--image-alt-font-size-large);
font-style: var(--image-alt-font-style);
color: var(--image-alt-color);
font-style: var(--image-alt-font-style);
}
img[data-img-loading-error] {
padding: var(--image-alt-spacing);
Expand Down
10 changes: 5 additions & 5 deletions localgov_base.theme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function localgov_base_form_system_theme_settings_alter(&$form, FormStateInterfa
return;
}

// Add settings in a details element for better organization
// Add settings in a details element for better organization.
$theme_info = \Drupal::service('theme.manager')->getActiveTheme()->getExtension()->info;
$theme_human_name = $theme_info['name'] ?? \Drupal::service('theme.manager')->getActiveTheme()->getName();
$form['localgov_base_settings'] = [
Expand All @@ -29,7 +29,7 @@ function localgov_base_form_system_theme_settings_alter(&$form, FormStateInterfa
'#open' => TRUE,
];

// Create a fieldset for general settings and place at the top
// Create a fieldset for general settings and place at the top.
$form['localgov_base_settings']['general_fieldset'] = [
'#type' => 'fieldset',
'#title' => t('General Settings'),
Expand Down Expand Up @@ -74,7 +74,7 @@ function localgov_base_form_system_theme_settings_alter(&$form, FormStateInterfa
'#default_value' => theme_get_setting('localgov_base_responsive_wysiwyg_tables') ? theme_get_setting('localgov_base_responsive_wysiwyg_tables') : FALSE,
];

// Create a fieldset for the CSS/JS library options
// Create a fieldset for the CSS/JS library options.
$form['localgov_base_settings']['libraries_fieldset'] = [
'#type' => 'fieldset',
'#title' => t('Theme Libraries'),
Expand All @@ -95,7 +95,7 @@ function localgov_base_form_system_theme_settings_alter(&$form, FormStateInterfa
'#description' => t("Check this box to disable the base theme's JavaScript"),
];

// Create a fieldset for content status related settings
// Create a fieldset for content status related settings.
$form['localgov_base_settings']['content_status_fieldset'] = [
'#type' => 'fieldset',
'#title' => t('Content Status Display'),
Expand Down Expand Up @@ -123,7 +123,7 @@ function localgov_base_form_system_theme_settings_alter(&$form, FormStateInterfa
'#description' => t('This adds the word "Archived" to the title of any content with the "archived" moderation state.'),
];

// Create a fieldset for guide-related settings
// Create a fieldset for guide-related settings.
$form['localgov_base_settings']['guides_fieldset'] = [
'#type' => 'fieldset',
'#title' => t('Guide Display Settings'),
Expand Down
Loading