Skip to content

Feature/811 once and context #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finnlewis merged 10 commits into from
Jul 8, 2025
Merged

Feature/811 once and context #812

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5f1320
adds support for facet forms
markconroy Oct 15, 2024
5f4a8df
adds more space between items
markconroy Oct 15, 2024
a51c952
Revert "Update .lgd-row classes to use CSS grid (#778)"
finnlewis May 29, 2025
9426dac
Revert "adds more space between items"
finnlewis May 29, 2025
d95ec80
Revert "adds support for facet forms"
finnlewis May 29, 2025
3d07056
Merge pull request #793 from localgovdrupal/feature/remove-duplicate-…
finnlewis May 29, 2025
ab2b058
use once and context instead of querySelector and document
markconroy Jun 24, 2025
08a1536
Adds extra defensive clause
markconroy Jun 25, 2025
a1d9ab8
resolving merge conflict
markconroy Jun 25, 2025
1a0883c
resolving merge conflict
markconroy Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions js/subsites-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@

const { mobileBreakpointJS } = drupalSettings.localgov_base;

const subsitesMenuToggle = document.querySelector(
'.subsite-extra__header-toggle-button',
);
const subsitesMenu = document.querySelector('.subsite-extra-menu');
const [subsitesMenuToggle] = once('allSubsitesMenuToggles', '.subsite-extra__header-toggle-button', context);
const [subsitesMenu] = once('allSubsitesMenuToggles', '.subsite-extra-menu', context);
Copy link
Contributor

@ctorgalson ctorgalson Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [subsitesMenu] = once('allSubsitesMenuToggles', '.subsite-extra-menu', context);
const [subsitesMenu] = once('allSubsitesMenuToggles', '.subsite-extra-menu', context);
if (!subsitesMenuToggle || !subsitesMenu) {
return;
}

This is untested, but it's the usual defensive companion to .once().

Copy link
Member Author

@markconroy markconroy Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctorgalson, I've added in the extra defensive clause now. Let me know if you think we're missing any thinbg.


if (!subsitesMenuToggle || !subsitesMenu) {
return;
}

subsitesMenuToggle.addEventListener('click', () => {
subsitesMenuToggle.setAttribute(
Expand Down Expand Up @@ -54,7 +56,7 @@
});

// Close the menu when a click is made outside of it.
document.addEventListener('click', (e) => {
context.addEventListener('click', (e) => {
if (!e.target.closest('#lgd-header__nav--subsites-menu')) {
handleReset();
}
Expand Down
Loading