-
Notifications
You must be signed in to change notification settings - Fork 19
Feature/2.x/805 add default accessible label to templates using localgov prev next #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
finnlewis
merged 7 commits into
2.x
from
feature/2.x/805-add-default-accessible-label-to-templates-using-localgov-prev-next
Jul 15, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3706be0
feat: adds new variables to prev-next SDC
ctorgalson 53c2b6b
feat: adds accessible label to Guides Prev-Next nav
ctorgalson c4393db
feat: adds accessible label to Blog Prev-Next nav
ctorgalson c42227a
feat: adds accessible label to Publication Prev-Next nav
ctorgalson 3712100
feat: adds accessible label to Step-by-Step Prev-Next nav
ctorgalson b7054d2
feat: adds missing documentation for prevNextAttributes prop
ctorgalson b8353f4
feat: makes ids of prev-next nav instances random
ctorgalson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| {% set nav_id = 'blogs-prev-next-' ~ random() %} | ||
| {% set prevNextAttributes = create_attribute({ id: nav_id }) %} | ||
| {% set prev_next_type = 'blog' %} | ||
| {% include 'localgov_base:prev-next' %} | ||
| {% embed 'localgov_base:prev-next' %} | ||
| {% block prev_next_pre_content %} | ||
| <h2 class="visually-hidden" aria-labelledby="{{ nav_id }}">{{ 'Blog navigation'|t }}</h2> | ||
markconroy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| {% endblock %} | ||
| {% endembed %} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.