Regression: Option to use the description for media links instead of the filename no longer works.

[rupertj]

The screenshot shows media embedded via the WYSIWYG. The links used to use the description of the media, but now use the filename, despite the option being checked to use the description.

I've seen the link get given the wrong title in localgov_base_preprocess_file_link(), which had recent changes. I'll investigate further to see they were the cause.

[rupertj]

So this got broken for us with the 2.2.0 release. If I roll H&F back to localgov_base 2.1.2 it works again.

[rupertj]

So it looks like this got broken for us by #849, which is odd, because it's trying to do the same thing we were already doing?

[tonypaulbarker]

The description field is not enabled by default (I think we arrived here because the naming in Drupal core is confusing). I found an old issue to turn it on localgovdrupal/localgov_core#47

I opened an MR to sketch out some code for handling both ways (code is not working for me though) but it might be cleaner in the long run to go back and use description instead of name.

[finnlewis]

Discussing in Merge Tuesday, @tonypaulbarker and @markconroy agree we should look to extend the logic here https://github.com/localgovdrupal/localgov_base/pull/849/files

To check for toggle 'use description as link text' and if set, do it!