drawStats() warnings

[whoisbma]

Occasionally I seem to get the following warning:

Pinpointing if the issue is part of my application or part of the libraries aside, I may ultimately need to disable the line of code that runs drawStats() in RUNNING state to prevent this from flashing onscreen (line 949, ofxApp.cpp in my version - case State::RUNNING: /*drawStats();*/ drawAnimatable(); break;). Should there be an override for this?

The reason I may not fix it in the end is because the source of this gl error might be down in some libraries that I haven't been interfacing very directly with (e.g. fontstash), and ultimately the invalid operation error doesn't cause any showstopper issues. In any case, I haven't found it yet.

As a separate point, since this part of drawStats() only gets drawn when ofxApp::utils::getGlError() returns something with a size over zero, this error only flashes onscreen for one frame. If its critical to be notified of GL issues in an app it seems like a possibly desirable solution would be to push the error message into a stack of them to gradually disappear onscreen, or just be moved into normal OF error logging.

Happy to hear any thoughts!

[whoisbma]

attaching @bensnell , who has reported a similar issue

[whoisbma]

I ended up just identifying the fbo draw calls that apparently create the error and empty the gl error buffer manually after those calls, rather than committing any change to an ofxApp fork. I think fixing whatever the issue is in my particular case is not practical at this point. But maybe the issue of how drawStats handles it is still worth looking at.

[armadillu]

Are you referring to his? https://github.com/local-projects/ofxApp/blob/master/src/ofxApp.cpp#L904
Ie getting the "OpenGL Error:" msg drawn? This is optional and is just meant for you to catch GL errors.

Feel free to send a PR adding a new ofxApp Setting similar to "drawGoogleAnalyticsState" to be able to disable the GL error message, but you are much better off trying to find the source of the GL error.

[whoisbma]

Definitely makes sense. I think that probably the only thing worth changing maybe would be the persistence of the GL error message appearing onscreen so that single frame issues can be more easily spotted, but that seems it would be a bigger fix to make.