Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: refactor cookie/headers to async mode #4459

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Oct 23, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

由于 next 15 把 header/cookie 等都改成了 async 模式,试了下在 14 中改成 await 也能正常跑,那么在 14 中先提前改起来。降低未来的迁移成本。

同时以 Discover 下面的页面为示例,修改了一波异步 params/searchParams

📝 补充信息 | Additional Information

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:27am
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:27am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 23, 2024
@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (7102393) to head (b404b3c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #4459     +/-   ##
=========================================
  Coverage   92.27%   92.27%             
=========================================
  Files         493      493             
  Lines       35691    35697      +6     
  Branches     3417     2167   -1250     
=========================================
+ Hits        32935    32941      +6     
  Misses       2756     2756             
Flag Coverage Δ
app 92.27% <100.00%> (+<0.01%) ⬆️
server 97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit 98c5d21 into main Oct 23, 2024
11 checks passed
@arvinxx arvinxx deleted the refactor/async-cookie-headers branch October 23, 2024 12:37
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
### [Version&nbsp;1.22.21](v1.22.20...v1.22.21)
<sup>Released on **2024-10-23**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor cookie/headers to async mode.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor cookie/headers to async mode, closes [#4459](#4459) ([98c5d21](98c5d21))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.22.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Oct 23, 2024
### [Version&nbsp;1.65.11](v1.65.10...v1.65.11)
<sup>Released on **2024-10-23**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor cookie/headers to async mode.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor cookie/headers to async mode, closes [lobehub#4459](https://github.com/bentwnghk/lobe-chat/issues/4459) ([98c5d21](98c5d21))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants