-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ perf: Use nextjs pwa feat to gen manifest file #4042
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for raising your pull request and contributing to our Community |
@@ -27,7 +27,7 @@ export const generateMetadata = async ({ params, searchParams }: Props) => { | |||
|
|||
const discoverService = new DiscoverService(); | |||
const data = await discoverService.getAssistantById(locale, identifier); | |||
if (!data) return notFound(); | |||
if (!data) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥 return 空?
src/app/manifest.ts
Outdated
import { translation } from '@/server/translation'; | ||
import { getCanonicalUrl } from '@/server/utils/url'; | ||
|
||
const genImage = (url: string, version: number = 1) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 提成单独的变量吧,不需要函数这里控制。
const VERSION = 1;
const genImage = (url: string) =>
BRANDING_LOGO_URL || qs.stringifyUrl({ query: { v: VERSION }, url });
<PWA | ||
description={t('chat.description', { appName: BRANDING_NAME })} | ||
id={PWA_INSTALL_ID} | ||
manifest-url={'/manifest.webmanifest'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifest-url={'/manifest.webmanifest'}
这个是干啥的
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4042 +/- ##
==========================================
+ Coverage 91.73% 92.45% +0.72%
==========================================
Files 481 482 +1
Lines 34195 34319 +124
Branches 2236 3216 +980
==========================================
+ Hits 31368 31730 +362
+ Misses 2827 2589 -238
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
测试已补充 |
Tests have been added |
❤️ Great PR @canisminor1990 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
🎉 This PR is included in version 1.19.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information