-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ fix: fix a corner case of tools_call
with empty object
#3955
Conversation
@hezhijie0327 is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
๐ @hezhijie0327 Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #3955 +/- ##
==========================================
+ Coverage 92.06% 92.08% +0.01%
==========================================
Files 460 460
Lines 31638 31717 +79
Branches 2152 2004 -148
==========================================
+ Hits 29127 29206 +79
Misses 2511 2511
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
ๅพ่ฎฉไปๆ stream ๆฟๅบๆฅ๏ผ็ถๅๅ ไธชๅๆต |
You have to ask him to take out the stream and add a single test |
ๆ็กฎไบ๏ผ#3983 (comment) ใไธๅคชๆณ่งฃ๏ผๆ่ง่ฟๆฏ new api ๅฏน้ฝ OpenAI ่ง่็้ฎ้ข |
I donโt understand clearly, #3983 (comment) |
Hey guys, can we already merge this pull request and fix the bug? |
oh sorry, seems is the same... |
Yes, of course, here's the stream. None of the models outputs the result to the chat o1:
4o:
|
Your API is from OpenAI or other provider? |
OpenAI, however, uses a corporate proxy to it. But the requests are not modified. |
Have you try current latest version? From stream seems no issue, basicly same as mine, and it's working
|
tools_call
with empty object
@abix5 can build on local and have a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
โค๏ธ Great PR @hezhijie0327 โค๏ธ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.17.7](v1.17.6...v1.17.7) <sup>Released on **2024-09-16**</sup> #### ๐ Bug Fixes - **misc**: Fix a corner case of `tools_call` with empty object. #### ๐ Styles - **misc**: Delete duplicate models in ollama. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix a corner case of `tools_call` with empty object, closes [#3955](#3955) ([d3fabdc](d3fabdc)) #### Styles * **misc**: Delete duplicate models in ollama, closes [#3989](#3989) ([ece60ee](ece60ee)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
๐ This PR is included in version 1.17.7 ๐ The release is available on: Your semantic-release bot ๐ฆ๐ |
### [Version 1.60.6](v1.60.5...v1.60.6) <sup>Released on **2024-09-17**</sup> #### ๐ Bug Fixes - **misc**: Fix a corner case of `tools_call` with empty object. #### ๐ Styles - **misc**: Delete duplicate models in ollama. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix a corner case of `tools_call` with empty object, closes [lobehub#3955](https://github.com/bentwnghk/lobe-chat/issues/3955) ([d3fabdc](d3fabdc)) #### Styles * **misc**: Delete duplicate models in ollama, closes [lobehub#3989](https://github.com/bentwnghk/lobe-chat/issues/3989) ([ece60ee](ece60ee)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
It worked, thank you very much. |
### [Version 1.17.7](lobehub/lobe-chat@v1.17.6...v1.17.7) <sup>Released on **2024-09-16**</sup> #### ๐ Bug Fixes - **misc**: Fix a corner case of `tools_call` with empty object. #### ๐ Styles - **misc**: Delete duplicate models in ollama. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix a corner case of `tools_call` with empty object, closes [lobehub#3955](lobehub#3955) ([d3fabdc](lobehub@d3fabdc)) #### Styles * **misc**: Delete duplicate models in ollama, closes [lobehub#3989](lobehub#3989) ([ece60ee](lobehub@ece60ee)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
ไผๅ Stream ๆตไธญ
content
ๆๅ ๅฎนๆถ็ๅคๅฎไผๅ ็บง๐ ่กฅๅ ไฟกๆฏ | Additional Information
็่ฎบไธ่ฝไฟฎๅค #3883 (comment) ไธญๆๅฐ็่ฟ็งๆ ๅต๏ผๅพ ้ช่ฏ