Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: fix .PDF can not be chunked #3720

Merged
merged 14 commits into from
Sep 3, 2024
Merged

🐛 fix: fix .PDF can not be chunked #3720

merged 14 commits into from
Sep 3, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Sep 1, 2024 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • 修正文件名后缀大写没有被正确识别的问题
  • 新增 RAG Eval 页面，通过 Feature Flag +rag_eval 开启

📝 补充信息 | Additional Information

refs: #3714

@vercel Vercel
Copy link

vercel bot commented Sep 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 1:09pm
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 1:09pm

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 1, 2024
@arvinxx arvinxx marked this pull request as draft September 1, 2024 15:54
@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@dosubot dosubot bot added the 🌠 Feature Request New feature or request | 特性与建议 label Sep 1, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.05747% with 26 lines in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (b95f70b) to head (03352db).
Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
src/services/upload.ts 0.00% 11 Missing ⚠️
src/store/file/slices/upload/action.ts 0.00% 8 Missing ⚠️
src/database/server/models/file.ts 36.36% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3720      +/-   ##
==========================================
+ Coverage   91.77%   91.79%   +0.02%     
==========================================
  Files         450      452       +2     
  Lines       29731    30021     +290     
  Branches     2910     1931     -979     
==========================================
+ Hits        27285    27559     +274     
- Misses       2446     2462      +16
Flag Coverage Δ
app 91.79% <85.05%> (+0.02%) ⬆️
server 97.36% <95.20%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title ✨ feat: support eval page ✨ feat: support rag eval page Sep 1, 2024
@vercel vercel bot temporarily deployed to Preview – lobe-chat-database September 3, 2024 04:07 Inactive
@arvinxx arvinxx changed the title ✨ feat: support rag eval page 🐛 fix: Sep 3, 2024
@arvinxx arvinxx changed the title 🐛 fix: 🐛 fix: fix .PDF can not be chunked Sep 3, 2024
@arvinxx arvinxx marked this pull request as ready for review September 3, 2024 13:28
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 3, 2024
@arvinxx arvinxx merged commit 4244c04 into main Sep 3, 2024
10 of 11 checks passed
@arvinxx arvinxx deleted the feat/support-benchmark branch September 3, 2024 13:28
@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Sep 3, 2024
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
@semantic-release-bot
🔖 chore(release): v1.15.8 [skip ci]
03f8a69 
### [Version&nbsp;1.15.8](v1.15.7...v1.15.8)
<sup>Released on **2024-09-03**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix `.PDF` can not be chunked.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix `.PDF` can not be chunked, closes [#3720](#3720) ([4244c04](4244c04))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.15.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 4, 2024
@semantic-release-bot
🔖 chore(release): v1.58.5 [skip ci]
bc000c5 
### [Version&nbsp;1.58.5](v1.58.4...v1.58.5)
<sup>Released on **2024-09-04**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix `.PDF` can not be chunked, fix speed and rag prompt.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix `.PDF` can not be chunked, closes [lobehub#3720](https://github.com/bentwnghk/lobe-chat/issues/3720) ([4244c04](4244c04))
* **misc**: Fix speed and rag prompt, closes [lobehub#3751](https://github.com/bentwnghk/lobe-chat/issues/3751) ([dce200c](dce200c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 🌠 Feature Request New feature or request | 特性与建议 released size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot