Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: improve s3 path-style url #3567

Merged
merged 1 commit into from
Aug 23, 2024
Merged

๐Ÿ› fix: improve s3 path-style url #3567

merged 1 commit into from
Aug 23, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Aug 23, 2024 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Aug 23, 2024 2:47am
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Aug 23, 2024 2:47am

@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.58%. Comparing base (bc6b64c) to head (c4fccc5).
Report is 608 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #3567     +/-   ##
=========================================
  Coverage   91.58%   91.58%             
=========================================
  Files         449      450      +1     
  Lines       29631    29644     +13     
  Branches     1958     3089   +1131     
=========================================
+ Hits        27137    27150     +13     
  Misses       2494     2494
Flag Coverage ฮ”
app 91.58% <100.00%> (+<0.01%) โฌ†๏ธ
server 96.79% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@arvinxx arvinxx merged commit 96bb38a into main Aug 23, 2024
12 checks passed
@arvinxx arvinxx deleted the fix/improve-minio branch August 23, 2024 02:53
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

@arvinxx arvinxx mentioned this pull request Aug 23, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.12.9 [skip ci]
320df5b 
### [Version&nbsp;1.12.9](v1.12.8...v1.12.9)
<sup>Released on **2024-08-23**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Improve s3 path-style url.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve s3 path-style url, closes [#3567](#3567) ([96bb38a](96bb38a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.12.9 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Aug 23, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.55.8 [skip ci]
5ed7045 
### [Version&nbsp;1.55.8](v1.55.7...v1.55.8)
<sup>Released on **2024-08-23**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Improve s3 path-style url.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve s3 path-style url, closes [lobehub#3567](https://github.com/bentwnghk/lobe-chat/issues/3567) ([96bb38a](96bb38a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
akvsdk pushed a commit to akvsdk/lobe-chat that referenced this pull request Aug 26, 2024
@arvinxx @akvsdk
๐Ÿ› fix: improve s3 path-style url (lobehub#3567)
cd505a2
akvsdk pushed a commit to akvsdk/lobe-chat that referenced this pull request Aug 26, 2024
@semantic-release-bot @akvsdk
๐Ÿ”– chore(release): v1.12.9 [skip ci]
1c049e3 
### [Version&nbsp;1.12.9](lobehub/lobe-chat@v1.12.8...v1.12.9)
<sup>Released on **2024-08-23**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Improve s3 path-style url.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve s3 path-style url, closes [lobehub#3567](lobehub#3567) ([96bb38a](lobehub@96bb38a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot