Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style(ui): Modify and repair UI layout #3321

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jul 26, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  • 修复助手名称过长而导致的显示问题
  • 修复模型选择中,由于模型名称过长导致的显示不完全
  • 修复模型ID模型名称过长,导致设置删除按钮消失的问题
  • 调整移动端的列表设置按钮显示样式
  • 修改移动端的自定义模型配置页面

  • Fix the display problem caused by the Assistant Name being too long.
  • Fix the problem that the display of the Model Name was incomplete due to it being too long in Model Selection.
  • Fix the problem where the Set and Delete buttons disappear when the Model ID or Model Name is too long.
  • Adjust the display style of list setting button.
  • Modify custom model configuration page on mobile

📝 补充信息 | Additional Information

Before After
BF1 AF1

Before After
BF2 AF2

Before After
BF3 AF3

Before After
BF4 AF4

Before After
BF5 AF5

Copy link

vercel bot commented Jul 26, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (ea798e5) to head (4362c21).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3321    +/-   ##
========================================
  Coverage   94.24%   94.24%            
========================================
  Files         400      400            
  Lines       25148    25154     +6     
  Branches     1839     2710   +871     
========================================
+ Hits        23700    23706     +6     
  Misses       1448     1448            
Flag Coverage Δ
app 94.24% <ø> (+<0.01%) ⬆️
server 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Jul 26, 2024

加一下 before 和 after 的对比?

@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 27, 2024

@arvinxx 助手的布局我改天再改,现在的以及修改完毕

I will modify the layout of the assistant another day. The current modification is complete.

@arvinxx
Copy link
Contributor

arvinxx commented Jul 29, 2024

@RubuJam model 的这个感觉不应该过长滚动,应该也是省略号比较好

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@RubuJam The feeling of the model should not be too long to scroll, and the ellipsis should be better

@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 29, 2024

@arvinxx 如果没有过长的,就不会显示滚动,不然直接省略,还是不太方便,毕竟这个不像设置里的,还有其他方式查看

If it is not too long, no scrolling will be displayed. Otherwise, it will be omitted directly, which is still not very convenient. This is not like in the settings. There are other ways to view it.

@RubuJam model 的这个感觉不应该过长滚动,应该也是省略号比较好

@arvinxx
Copy link
Contributor

arvinxx commented Jul 29, 2024

如果没有过长的,就不会显示滚动,不然直接省略,还是不太方便,毕竟这个不像设置里的,还有其他方式查看

Antd 的 Typography 是支持 ellpsis 用tooltip 展示的,可以试试看。https://ant-design.antgroup.com/components/typography-cn#components-typography-demo-ellipsis

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:17am

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, Thanks for your contribution~

@arvinxx arvinxx merged commit cda776f into lobehub:main Jul 30, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
### [Version&nbsp;1.7.8](v1.7.7...v1.7.8)
<sup>Released on **2024-07-30**</sup>

#### 💄 Styles

- **ui**: Modify and repair UI layout.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Modify and repair UI layout, closes [#3321](#3321) ([cda776f](cda776f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.7.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RubuJam RubuJam deleted the fix/title branch July 30, 2024 07:47
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 30, 2024
### [Version&nbsp;1.50.7](v1.50.6...v1.50.7)
<sup>Released on **2024-07-30**</sup>

#### 💄 Styles

- **ui**: Modify and repair UI layout.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Modify and repair UI layout, closes [lobehub#3321](https://github.com/bentwnghk/lobe-chat/issues/3321) ([cda776f](cda776f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants