Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: Avoid baseURL being an empty string, resulting in incorrect cl… #3308

Merged
merged 1 commit into from
Jul 26, 2024
Merged

🐛 fix: Avoid baseURL being an empty string, resulting in incorrect cl… #3308

merged 1 commit into from
Jul 26, 2024

Conversation

mosade
Copy link
Contributor

@mosade mosade commented Jul 25, 2024 •
edited by arvinxx
Loading

When baseURL="", baseURL should be set to DEFAULT_BASE_URL in client fetch
close #3307, close #3316

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

@vercel Vercel
Copy link

vercel bot commented Jul 25, 2024

@mosade is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @mosade

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (5f4491a) to head (e3d30e2).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3308   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         398      398           
  Lines       24893    24899    +6     
  Branches     2884     2810   -74     
=======================================
+ Hits        23445    23451    +6     
  Misses       1448     1448
Flag Coverage Δ
app 94.18% <100.00%> (+<0.01%) ⬆️
server 68.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZachZimm ZachZimm mentioned this pull request Jul 25, 2024
Closed
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 11:18am

@arvinxx arvinxx merged commit 15a9bc1 into lobehub:main Jul 26, 2024
8 of 9 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @mosade ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@semantic-release-bot
🔖 chore(release): v1.7.2 [skip ci]
9b4c39c 
### [Version&nbsp;1.7.2](v1.7.1...v1.7.2)
<sup>Released on **2024-07-26**</sup>

#### 🐛 Bug Fixes

- **misc**: Avoid baseURL being an empty string, resulting in incorrect client fetch.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Avoid baseURL being an empty string, resulting in incorrect client fetch, closes [#3308](#3308) ([15a9bc1](15a9bc1))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 26, 2024
@semantic-release-bot
🔖 chore(release): v1.50.2 [skip ci]
6b52759 
### [Version&nbsp;1.50.2](v1.50.1...v1.50.2)
<sup>Released on **2024-07-26**</sup>

#### 🐛 Bug Fixes

- **misc**: Avoid baseURL being an empty string, resulting in incorrect client fetch.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Avoid baseURL being an empty string, resulting in incorrect client fetch, closes [lobehub#3308](https://github.com/bentwnghk/lobe-chat/issues/3308) ([15a9bc1](15a9bc1))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@mosade @lobehubbot @arvinxx