Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: fix create_session edit_agent feature flags and add more flags #3289

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

Mingholy
Copy link
Contributor

@Mingholy Mingholy commented Jul 22, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

增加feature_flags以支持定制更精简的lobe-chat。

  • create_session bugfix
  • edit_agent bugfix
  • market
  • speech

📝 补充信息 | Additional Information

create_session bugfix

基于#538#1318 的讨论,目前看agent、session、assistant在lobe-chat产品概念中是一个层面的东西。因此如果通过create_sessionflag禁用了创建会话功能,则所有创建助手的功能应该都不可用/隐藏掉。

目前仅助手栏右上角创建图标和列表下方创建按钮会针对该flag生效;Chat中默认的消息、Dropdown中的『新建助手』item不受此flag影响。
image


edit_agent bugfix

创建的新助手,默认会显示agentDefaultMessage你好,我是 **{{name}}**,你可以立即与我开始对话,也可以前往 [助手设置](/chat/settings#session={{id}}) 完善我的信息。,该信息在设置-edit_agent时应去除设置相关的内容。
image
image


market

新增market,是否显示『发现』;默认显示。


speech

新增speech,是否显示『语音设置』和prompt输入框上方的麦克风按钮;默认显示。

Copy link

vercel bot commented Jul 22, 2024

@Mingholy is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @Mingholy

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (15a9bc1) to head (57225dc).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3289      +/-   ##
==========================================
+ Coverage   94.19%   94.21%   +0.02%     
==========================================
  Files         398      400       +2     
  Lines       24935    25046     +111     
  Branches     1943     2707     +764     
==========================================
+ Hits        23487    23598     +111     
  Misses       1448     1448              
Flag Coverage Δ
app 94.21% <100.00%> (+0.02%) ⬆️
server 68.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mingholy Mingholy marked this pull request as ready for review July 22, 2024 10:03
src/app/(main)/@nav/_layout/Desktop/TopActions.tsx Outdated Show resolved Hide resolved
src/app/(main)/@nav/_layout/Mobile.tsx Outdated Show resolved Hide resolved
src/config/featureFlags/schema.ts Outdated Show resolved Hide resolved
@Mingholy Mingholy marked this pull request as draft July 26, 2024 02:12
@Mingholy Mingholy marked this pull request as ready for review July 26, 2024 08:36
@Mingholy
Copy link
Contributor Author

Mingholy commented Jul 26, 2024

补充了Welome中的按钮控制及单测。
image
image

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 0:10am

@arvinxx arvinxx changed the title ✨ feat: Update feature flags 🐛 fix: fix create_session edit_agent feature flags and add more flags Jul 29, 2024
@arvinxx arvinxx merged commit ebfd3cf into lobehub:main Jul 29, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @Mingholy ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.7.5](v1.7.4...v1.7.5)
<sup>Released on **2024-07-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix `create_session ` `edit_agent` feature flags  and add more flags.

#### 💄 Styles

- **misc**: Update 360GPT model (360GPT2 Pro).

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix `create_session ` `edit_agent` feature flags  and add more flags, closes [#3289](#3289) ([ebfd3cf](ebfd3cf))

#### Styles

* **misc**: Update 360GPT model (360GPT2 Pro), closes [#3339](#3339) ([c8ed85e](c8ed85e))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.50.4](v1.50.3...v1.50.4)
<sup>Released on **2024-07-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix `create_session ` `edit_agent` feature flags  and add more flags, improve remote model list fetching for Novita AI.

#### 💄 Styles

- **misc**: Update 360GPT model (360GPT2 Pro).

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix `create_session ` `edit_agent` feature flags  and add more flags, closes [lobehub#3289](https://github.com/bentwnghk/lobe-chat/issues/3289) ([ebfd3cf](ebfd3cf))
* **misc**: Improve remote model list fetching for Novita AI, closes [lobehub#3311](https://github.com/bentwnghk/lobe-chat/issues/3311) ([67b9ff0](67b9ff0))

#### Styles

* **misc**: Update 360GPT model (360GPT2 Pro), closes [lobehub#3339](https://github.com/bentwnghk/lobe-chat/issues/3339) ([c8ed85e](c8ed85e))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants