Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: Add new model provider Novita AI #3177

Merged
merged 23 commits into from
Jul 23, 2024

Conversation

jasonhp
Copy link
Contributor

@jasonhp jasonhp commented Jul 9, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  1. Add new model provider: Novita AI
  2. FIx test case: OPENROUTER_MODEL_LIST, and its snapshot.

📝 补充信息 | Additional Information

Copy link

vercel bot commented Jul 9, 2024

@jasonhp is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @jasonhp

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 92.80576% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.18%. Comparing base (ef54191) to head (683d87f).
Report is 1 commits behind head on main.

Files Patch % Lines
src/app/api/chat/agentRuntime.ts 14.28% 6 Missing ⚠️
src/libs/agent-runtime/AgentRuntime.ts 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
- Coverage   94.18%   94.18%   -0.01%     
==========================================
  Files         396      398       +2     
  Lines       24755    24893     +138     
  Branches     2806     1831     -975     
==========================================
+ Hits        23316    23445     +129     
- Misses       1439     1448       +9     
Flag Coverage Δ
app 94.18% <92.80%> (-0.01%) ⬇️
server 68.71% <94.35%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/app/(main)/settings/llm/ProviderList/providers.tsx Outdated Show resolved Hide resolved
src/config/modelProviders/baichuan.ts Outdated Show resolved Hide resolved
src/libs/agent-runtime/baichuan/index.ts Outdated Show resolved Hide resolved
@lobehub lobehub deleted a comment from lobehubbot Jul 9, 2024
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还需要补充一篇配置文档,参考:https://lobehub.com/zh/docs/usage/providers/qwen

cy948 and others added 11 commits July 12, 2024 13:28
* ♻️ refactor: Support disable clientFetch by modelConfig (lobehub#3108)

* ✅ test: - clientfetch for qwen

* ♻️ refactor: Remove `defaultShowBrowserRequest` in qwen modelConfig
### [Version&nbsp;1.3.4](lobehub/lobe-chat@v1.3.3...v1.3.4)
<sup>Released on **2024-07-09**</sup>

#### ♻ Code Refactoring

- **misc**: Support disable clientFetch by default.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Support disable clientFetch by default, closes [lobehub#3133](lobehub#3133) [lobehub#3108](lobehub#3108) ([4415652](lobehub@4415652))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
### [Version&nbsp;1.3.5](lobehub/lobe-chat@v1.3.4...v1.3.5)
<sup>Released on **2024-07-10**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix assistant meta change race issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix assistant meta change race issue, closes [lobehub#3184](lobehub#3184) ([6335be4](lobehub@6335be4))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
* ♻️ refactor: improve agent runtime code

* ♻️ refactor: clean code
### [Version&nbsp;1.3.6](lobehub/lobe-chat@v1.3.5...v1.3.6)
<sup>Released on **2024-07-11**</sup>

#### ♻ Code Refactoring

- **misc**: Improve agent runtime code.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Improve agent runtime code, closes [lobehub#3199](lobehub#3199) ([9f211e2](lobehub@9f211e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是合并有问题,出现了很多重复添加的情况

src/app/(main)/settings/llm/ProviderList/providers.tsx Outdated Show resolved Hide resolved
src/components/ModelProviderIcon/index.tsx Show resolved Hide resolved
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:02am

@arvinxx arvinxx changed the title Add new model provider Novita AI 💄 style: Add new model provider Novita AI Jul 22, 2024
@arvinxx
Copy link
Contributor

arvinxx commented Jul 22, 2024

image

我测试了下,你们的接口似乎不支持 client fetch,需要加个配置把 client fetch 禁用掉。disableBrowserRequest: true。参考:
https://github.com/lobehub/lobe-chat/blob/main/src/config/modelProviders/qwen.ts#L77

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, Thanks for your great work!

@arvinxx arvinxx merged commit 08b063f into lobehub:main Jul 23, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @jasonhp ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
### [Version&nbsp;1.6.7](v1.6.6...v1.6.7)
<sup>Released on **2024-07-23**</sup>

#### 💄 Styles

- **misc**: Add new model provider Novita AI.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add new model provider Novita AI, closes [#3177](#3177) ([08b063f](08b063f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 23, 2024
### [Version&nbsp;1.49.5](v1.49.4...v1.49.5)
<sup>Released on **2024-07-23**</sup>

#### ♻ Code Refactoring

- **misc**: Move server modules.

#### 💄 Styles

- **misc**: Add new model provider Novita AI.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Move server modules, closes [lobehub#3291](https://github.com/bentwnghk/lobe-chat/issues/3291) ([c7c9f39](c7c9f39))

#### Styles

* **misc**: Add new model provider Novita AI, closes [lobehub#3177](https://github.com/bentwnghk/lobe-chat/issues/3177) ([08b063f](08b063f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@xenstar
Copy link

xenstar commented Jul 25, 2024

@jasonhp Seems the get model list button doesn't work. It can't get the latest Llama 3.1 models.

image

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.6.7](lobehub/lobe-chat@v1.6.6...v1.6.7)
<sup>Released on **2024-07-23**</sup>

#### 💄 Styles

- **misc**: Add new model provider Novita AI.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add new model provider Novita AI, closes [lobehub#3177](lobehub#3177) ([08b063f](lobehub@08b063f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants