Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ perf: Optimize Cache-Control #2848

Merged
merged 1 commit into from
Jun 17, 2024
Merged

⚡️ perf: Optimize Cache-Control #2848

merged 1 commit into from
Jun 17, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jun 11, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  • 🐛 升级@lobehub/ui,由^1.141.2^1.142.4,修复💄 style: Expand Clear tooltip maxWidth中,由于@lobehub/ui原有版本较低所产生的问题

  • 💄 优化图片、manifest.jsonOpen Graph中的缓存控制


  • 🐛 It is recommended that the @lobehub/ui package be upgraded from version 1.141.2 to 1.142.4. This will address the issue identified in 💄 style: Expand Clear tooltip maxWidth, which was caused by the lower original version of @lobehub/ui.

  • 💄 Optimize the cache control of images, Open Graph and manifest.json.

📝 补充信息 | Additional Information

  • manifest.json中的图片添加版本信息,若所涉图片更新,手动更改其版本号即可

  • Open Graph(src/app/metadata.tssrc/server/metadata.ts )中的图片添加版本信息,若所涉图片更新,手动更改其版本号即可


  • Add version information be added to the images included in the manifest.json file. In the event that the images in question undergo an update, it is sufficient to manually alter their version numbers.

  • Add version information be added to the images included in the Open Graph( src/app/metadata.ts and src/server/metadata.ts ). In the event that the images in question undergo an update, it is sufficient to manually alter their version numbers.


Before:
Before

After:
After

Copy link

vercel bot commented Jun 11, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (19fd4d5) to head (ddcd54c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2848    +/-   ##
========================================
  Coverage   93.25%   93.25%            
========================================
  Files         380      380            
  Lines       23795    23795            
  Branches     2543     2663   +120     
========================================
  Hits        22190    22190            
  Misses       1605     1605            
Flag Coverage Δ
app 93.25% <ø> (ø)
server 65.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Jun 17, 2024

@RubuJam 构建挂了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@RubuJam build hangs

@RubuJam
Copy link
Contributor Author

RubuJam commented Jun 17, 2024

已经修复 @arvinxx

already fixed @arvinxx

@RubuJam RubuJam requested a review from arvinxx June 17, 2024 10:30
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Fixed @arvinxx

already fixed @arvinxx

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for your contribution~

@arvinxx arvinxx changed the title 💄 style: Optimize Cache-Control ⚡️ perf: Optimize Cache-Control Jun 17, 2024
@arvinxx arvinxx merged commit fbc488e into lobehub:main Jun 17, 2024
7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@RubuJam RubuJam deleted the cache branch June 17, 2024 14:00
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants