Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ perf: improve performance of session navigation #2815

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Jun 8, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

研究下来 Link 的行为不是我一开始以为的 router.push 的单页跳转,而是和普通 a 标签的跳转效果一样。因此使用 Link 会导致切换助手卡顿… 改成用 state 触发变更就好了

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 3:42am

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.07%. Comparing base (7bb4fec) to head (b9e589e).
Report is 1008 commits behind head on main.

Files with missing lines Patch % Lines
src/store/session/slices/session/action.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2815      +/-   ##
==========================================
- Coverage   94.07%   94.07%   -0.01%     
==========================================
  Files         359      359              
  Lines       20827    20826       -1     
  Branches     2490     1596     -894     
==========================================
- Hits        19593    19592       -1     
  Misses       1234     1234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx marked this pull request as ready for review June 8, 2024 03:56
@arvinxx arvinxx merged commit b32f428 into main Jun 8, 2024
9 of 10 checks passed
@arvinxx arvinxx deleted the perf/session-click branch June 8, 2024 03:57
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.162.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
* ⚡️ perf: improve performance of session navigation

* 🐛 fix: fix mobile navigation

* ♻️ refactor: clean code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants