Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ“ docs: update docs #2669

Merged
merged 5 commits into from
May 27, 2024
Merged

๐Ÿ“ docs: update docs #2669

merged 5 commits into from
May 27, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented May 26, 2024

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

ๆ›ดๆ–ฐ้ƒจๅˆ†ๆ–‡ๆกฃ

Update some documents

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Summary by CodeRabbit

  • Documentation
    • Renumbered and linked sections in the Feature-Development.md document for improved clarity and navigation.
    • Refined language and structure in the Intro.md guide, adding sections on local development setup, code style, contribution guidelines, internationalization, and additional resources.
    • Added an important note in Intro.zh-CN.md regarding the npm run stylelint-config-recommended@13.0.0 command to prevent setup errors.

Copy link

vercel bot commented May 26, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented May 26, 2024

Walkthrough

The recent updates primarily focus on refining the documentation for feature development and contribution guidelines. Key changes include renumbering and linking sections for better navigation, introducing new sections for local development setup, code style, contribution guidelines, and internationalization. Additionally, an important note was added to avoid errors during code commits.

Changes

Files/Paths Change Summary
contributing/Basic/Feature-Development.md Renumbered and linked sections for better clarity and navigation.
contributing/Basic/Feature-Development.zh-CN.md Reordered and renamed sections related to session group management without altering core functionality.
contributing/Basic/Intro.md Refined language and structure, added sections for local development setup, code style, contribution guidelines, internationalization, and resources.
contributing/Basic/Intro.zh-CN.md Added an important note regarding running npm run stylelint-config-recommended@13.0.0 before committing code.

In docs, we find our way,
Through numbered paths and clear display.
With guides to set our code just right,
And languages to make our chat ignite.
A rabbit's touch to lead the way,
In LobeChat, we code and play.
๐ŸŒŸ๐Ÿ‡โœจ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lobehubbot
Copy link
Member

๐Ÿ‘ @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (11)
contributing/Basic/Intro.zh-CN.md (1)

Line range hint 111-111: Improve grammatical structure for better readability.

- ๅฆ‚ๆžœไฝ ๆœ‰ไปปไฝ•็–‘้—ฎ๏ผŒๆˆ–่€…้œ€่ฆ่ฟ›ไธ€ๆญฅ็š„ๅธฎๅŠฉ๏ผŒ่ฏทไธ่ฆ็Šน่ฑซ๏ผŒ่ฏท้€š่ฟ‡ไธŠ่ฟฐๆธ ้“ไธŽๆˆ‘ไปฌ่”็ณปใ€‚
+ ๅฆ‚ๆžœไฝ ๆœ‰ไปปไฝ•็–‘้—ฎๆˆ–้œ€่ฆ่ฟ›ไธ€ๆญฅๅธฎๅŠฉ๏ผŒ่ฏทไธ่ฆ็Šน่ฑซ๏ผŒ้€š่ฟ‡ไธŠ่ฟฐๆธ ้“ไธŽๆˆ‘ไปฌ่”็ณปใ€‚
contributing/Basic/Feature-Development.zh-CN.md (4)

Line range hint 204-204: Improve grammatical accuracy in the sentence.

- ้€š่ฟ‡ไปฅไธŠ็š„ๅฎž็Žฐ๏ผŒๆˆ‘ไปฌๅฏไปฅ็กฎไฟๅœจๆทปๅŠ ๆ–ฐ็š„ไผš่ฏ็ป„ๅŽ๏ผŒๅบ”็”จ็š„็Šถๆ€ไผšๅŠๆ—ถๆ›ดๆ–ฐ๏ผŒไธ”็›ธๅ…ณ็š„็ป„ไปถไผšๆ”ถๅˆฐๆœ€ๆ–ฐ็š„็Šถๆ€ๅนถ้‡ๆ–ฐๆธฒๆŸ“ใ€‚่ฟ™็งๆ–นๅผ...
+ ้€š่ฟ‡ไปฅไธŠ็š„ๅฎž็Žฐ๏ผŒๆˆ‘ไปฌๅฏไปฅ็กฎไฟๅœจๆทปๅŠ ๆ–ฐ็š„ไผš่ฏ็ป„ๅŽ๏ผŒๅบ”็”จ็š„็Šถๆ€ไผšๅŠๆ—ถๆ›ดๆ–ฐ๏ผŒไธ”็›ธๅ…ณ็š„็ป„ไปถไผšๆ”ถๅˆฐๆœ€ๆ–ฐ็Šถๆ€ๅนถ้‡ๆ–ฐๆธฒๆŸ“ใ€‚่ฟ™็งๆ–นๅผ...

Line range hint 268-268: Ensure grammatical consistency in the documentation.

- ่ฟ™ๅฐ†ไฟ่ฏ็Šถๆ€ไธŽๆœ€ๆ–ฐ็š„ไผš่ฏๆ•ฐๆฎๅŒๆญฅใ€‚
+ ่ฟ™ๅฐ†็กฎไฟ็Šถๆ€ไธŽๆœ€ๆ–ฐ็š„ไผš่ฏๆ•ฐๆฎไฟๆŒๅŒๆญฅใ€‚

Line range hint 319-319: Adjust the sentence for better clarity and grammatical accuracy.

- ้ฆ–ๅ…ˆๆŸฅ่ฏขๆ‰€ๆœ‰ไผš่ฏ็ป„๏ผŒ็„ถๅŽๅŸบไบŽ่ฟ™ไบ›็ป„็š„ ID ๆŸฅ่ฏข่‡ชๅฎšไน‰ไผš่ฏ็ป„๏ผŒๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎš็š„ไผš่ฏใ€‚ๆœ€ๅŽ๏ผŒๅฎƒ่ฟ”ๅ›žไธ€ไธชๅŒ…ๅซๆ‰€ๆœ‰ไผš่ฏๅ’ŒๆŒ‰็ป„ๅˆ†็ฑป็š„ไผš่ฏๅˆ—่กจๅฏน่ฑกใ€‚
+ ้ฆ–ๅ…ˆๆŸฅ่ฏขๆ‰€ๆœ‰ไผš่ฏ็ป„๏ผŒ็„ถๅŽๅŸบไบŽ่ฟ™ไบ›็ป„็š„ ID ๆŸฅ่ฏข่‡ชๅฎšไน‰ไผš่ฏ็ป„๏ผŒๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎš็š„ไผš่ฏใ€‚ๆœ€ๅŽ๏ผŒ่ฟ”ๅ›žไธ€ไธชๅŒ…ๅซๆ‰€ๆœ‰ไผš่ฏๅ’ŒๆŒ‰็ป„ๅˆ†็ฑป็š„ไผš่ฏๅˆ—่กจๅฏน่ฑกใ€‚

Line range hint 120-120: Add alternative text to images for accessibility.

- ![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
contributing/Basic/Feature-Development.md (6)

Line range hint 120-120: Images should have alternate text (alt text) for accessibility.

- ![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Line range hint 391-391: Fenced code blocks should have a language specified for better readability.

- ```diff
+ ```diff javascript

Also applies to: 522-522


Line range hint 465-465: Consider replacing "very simple" with "straightforward" to avoid overused intensifiers.

- ...en that the migration implementation is very simple. However, it is important to ensure the...
+ ...en that the migration implementation is straightforward. However, it is important to ensure the...

Line range hint 607-609: Loose punctuation marks should be corrected.

- "version": 3 } ```
+ "version": 3 }

Line range hint 637-637: Avoid repetitive phrasing to enhance readability.

- ...tation of the Session Group feature, we need to handle the `sessionGroups` data during ...
+ ...tation of the Session Group feature, it's necessary to manage the `sessionGroups` data during ...

Line range hint 709-709: Rephrase to avoid repetitive sentence beginnings.

- This approach ensures that users' Session Group data is correctly handled during the import and export process.
+ This method guarantees that users' Session Group data is correctly handled during the import and export process.
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fe95f31 and 1d33382.
Files selected for processing (4)
  • contributing/Basic/Feature-Development.md (3 hunks)
  • contributing/Basic/Feature-Development.zh-CN.md (1 hunks)
  • contributing/Basic/Intro.md (2 hunks)
  • contributing/Basic/Intro.zh-CN.md (1 hunks)
Additional Context Used
LanguageTool (13)
contributing/Basic/Feature-Development.md (7)

Near line 465: As an alternative to the over-used intensifier โ€˜veryโ€™, consider replacing this phrase.
Context: ...en that the migration implementation is very simple. However, it is important to ensure the...
Rule ID: EN_WEAK_ADJECTIVE


Near line 575: โ€˜exactly the sameโ€™ might be wordy. Consider a shorter alternative.
Context: ... complete exported data can be restored exactly the same on other devices. The core implementat...
Rule ID: EN_WORDINESS_PREMIUM_EXACTLY_THE_SAME


Near line 607: Loose punctuation mark.
Context: ...ersion": 3 } ``` Where: - exportType: Identifies the type of data being expor...
Rule ID: UNLIKELY_OPENING_PUNCTUATION


Near line 608: Loose punctuation mark.
Context: ...agent, settings, and all. - state`: Stores the actual data, with different ...
Rule ID: UNLIKELY_OPENING_PUNCTUATION


Near line 609: Loose punctuation mark.
Context: ... for different exportType. - version: Indicates the data version. In the imp...
Rule ID: UNLIKELY_OPENING_PUNCTUATION


Near line 637: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...tation of the Session Group feature, we need to handle the sessionGroups data during ...
Rule ID: REP_NEED_TO_VB


Near line 709: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... in the data import and export process. This approach ensures that users' Session Gr...
Rule ID: ENGLISH_WORD_REPEAT_BEGINNING_RULE

contributing/Basic/Feature-Development.zh-CN.md (4)

Near line 204: ๅŠจ่ฏ็š„ไฟฎ้ฅฐไธ€่ˆฌไธบโ€˜ๅฝขๅฎน่ฏ๏ผˆๅ‰ฏ่ฏ๏ผ‰+ๅœฐ+ๅŠจ่ฏโ€™ใ€‚ๆ‚จ็š„ๆ„ๆ€ๆ˜ฏๅฆๆ˜ฏ๏ผšๆ–ฐ"ๅœฐ"ไผš่ฏ
Context: ...onService็š„createSessionGroupๆ–นๆณ•ๆฅๅˆ›ๅปบๆ–ฐ็š„ไผš่ฏ็ป„๏ผŒ็„ถๅŽไฝฟ็”จrefreshSessions` ๆ–นๆณ•ๆฅๅˆทๆ–ฐ session...
Rule ID: wb4


Near line 226: ๅŠจ่ฏ็š„ไฟฎ้ฅฐไธ€่ˆฌไธบโ€˜ๅฝขๅฎน่ฏ๏ผˆๅ‰ฏ่ฏ๏ผ‰+ๅœฐ+ๅŠจ่ฏโ€™ใ€‚ๆ‚จ็š„ๆ„ๆ€ๆ˜ฏๅฆๆ˜ฏ๏ผšๆ–ฐ"ๅœฐ"ไผš่ฏ
Context: ...ๅ…ถไป– action ๅฎž็Žฐ }); ``` ้€š่ฟ‡ไปฅไธŠ็š„ๅฎž็Žฐ๏ผŒๆˆ‘ไปฌๅฏไปฅ็กฎไฟๅœจๆทปๅŠ ๆ–ฐ็š„ไผš่ฏ็ป„ๅŽ๏ผŒๅบ”็”จ็š„็Šถๆ€ไผšๅŠๆ—ถๆ›ดๆ–ฐ๏ผŒไธ”็›ธๅ…ณ็š„็ป„ไปถไผšๆ”ถๅˆฐๆœ€ๆ–ฐ็š„็Šถๆ€ๅนถ้‡ๆ–ฐๆธฒๆŸ“ใ€‚่ฟ™็งๆ–นๅผ...
Rule ID: wb4


Near line 268: ๅŠจ่ฏ็š„ไฟฎ้ฅฐไธ€่ˆฌไธบโ€˜ๅฝขๅฎน่ฏ๏ผˆๅ‰ฏ่ฏ๏ผ‰+ๅœฐ+ๅŠจ่ฏโ€™ใ€‚ๆ‚จ็š„ๆ„ๆ€ๆ˜ฏๅฆๆ˜ฏ๏ผšๆœ€ๆ–ฐ"ๅœฐ"ไผš่ฏ
Context: ...innedSessionsๅ’Œsessions็Šถๆ€ใ€‚่ฟ™ๅฐ†ไฟ่ฏ็Šถๆ€ไธŽๆœ€ๆ–ฐ็š„ไผš่ฏๆ•ฐๆฎๅŒๆญฅใ€‚ #### getGroupedSessions ไฝฟ็”จse...
Rule ID: wb4


Near line 319: ๅŠจ่ฏ็š„ไฟฎ้ฅฐไธ€่ˆฌไธบโ€˜ๅฝขๅฎน่ฏ๏ผˆๅ‰ฏ่ฏ๏ผ‰+ๅœฐ+ๅŠจ่ฏโ€™ใ€‚ๆ‚จ็š„ๆ„ๆ€ๆ˜ฏๅฆๆ˜ฏ๏ผšๅ›บๅฎš"ๅœฐ"ไผš่ฏ
Context: ...้ฆ–ๅ…ˆๆŸฅ่ฏขๆ‰€ๆœ‰ไผš่ฏ็ป„๏ผŒ็„ถๅŽๅŸบไบŽ่ฟ™ไบ›็ป„็š„ ID ๆŸฅ่ฏข่‡ชๅฎšไน‰ไผš่ฏ็ป„๏ผŒๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎš็š„ไผš่ฏใ€‚ๆœ€ๅŽ๏ผŒๅฎƒ่ฟ”ๅ›žไธ€ไธชๅŒ…ๅซๆ‰€ๆœ‰ไผš่ฏๅ’ŒๆŒ‰็ป„ๅˆ†็ฑป็š„ไผš่ฏๅˆ—่กจๅฏน่ฑกใ€‚ ### sess...
Rule ID: wb4

contributing/Basic/Intro.md (1)

Near line 80: The word โ€œotherwiseโ€ is an adverb that canโ€™t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...ommended@13.0.0before committing your code, otherwise you will encounter the errorCould not...
Rule ID: THUS_SENTENCE

contributing/Basic/Intro.zh-CN.md (1)

Near line 111: ๅŠจ่ฏ็š„ไฟฎ้ฅฐไธ€่ˆฌไธบโ€˜ๅฝขๅฎน่ฏ๏ผˆๅ‰ฏ่ฏ๏ผ‰+ๅœฐ+ๅŠจ่ฏโ€™ใ€‚ๆ‚จ็š„ๆ„ๆ€ๆ˜ฏๅฆๆ˜ฏ๏ผš่ฟ›ไธ€ๆญฅ"ๅœฐ"ๅธฎๅŠฉ
Context: ...T) ๅŠ ๅ…ฅ็คพๅŒบ่ฎจ่ฎบ๏ผŒๆๅ‡บ้—ฎ้ข˜ๆˆ–ๅˆ†ไบซไฝ ็š„็ป้ชŒใ€‚ ๅฆ‚ๆžœไฝ ๆœ‰ไปปไฝ•็–‘้—ฎ๏ผŒๆˆ–่€…้œ€่ฆ่ฟ›ไธ€ๆญฅ็š„ๅธฎๅŠฉ๏ผŒ่ฏทไธ่ฆ็Šน่ฑซ๏ผŒ่ฏท้€š่ฟ‡ไธŠ่ฟฐๆธ ้“ไธŽๆˆ‘ไปฌ่”็ณปใ€‚
Rule ID: wb4

Markdownlint (9)
contributing/Basic/Feature-Development.md (4)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


522: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Feature-Development.zh-CN.md (3)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Intro.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

contributing/Basic/Intro.zh-CN.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

Additional comments not posted (1)
contributing/Basic/Feature-Development.md (1)

7-12: Renumbered sections improve document navigation.

contributing/Basic/Feature-Development.md Show resolved Hide resolved
contributing/Basic/Feature-Development.md Outdated Show resolved Hide resolved
contributing/Basic/Intro.zh-CN.md Outdated Show resolved Hide resolved
contributing/Basic/Intro.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 94.04%. Comparing base (56865fe) to head (89c50f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2669    +/-   ##
========================================
  Coverage   94.04%   94.04%            
========================================
  Files         356      356            
  Lines       20567    20567            
  Branches     2458     1575   -883     
========================================
  Hits        19342    19342            
  Misses       1225     1225            

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (3)
contributing/Basic/Intro.zh-CN.md (1)

Line range hint 5-5: Adjust heading levels for consistency.

- #### TOC
+ ## TOC
contributing/Basic/Feature-Development.zh-CN.md (2)

Line range hint 204-204: Correct the adverbial usage in Chinese for clarity.

- ๅˆ›ๅปบๆ–ฐ็š„ไผš่ฏ็ป„
+ ๅˆ›ๅปบๆ–ฐๅœฐไผš่ฏ็ป„

- ๆทปๅŠ ๆ–ฐ็š„ไผš่ฏ็ป„ๅŽ
+ ๆทปๅŠ ๆ–ฐๅœฐไผš่ฏ็ป„ๅŽ

- ็Šถๆ€ไธŽๆœ€ๆ–ฐ็š„ไผš่ฏๆ•ฐๆฎๅŒๆญฅ
+ ็Šถๆ€ไธŽๆœ€ๆ–ฐๅœฐไผš่ฏๆ•ฐๆฎๅŒๆญฅ

- ๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎš็š„ไผš่ฏ
+ ๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎšๅœฐไผš่ฏ

Also applies to: 226-226, 268-268, 319-319


Line range hint 391-391: Specify the language for code blocks to enable syntax highlighting.

- ```tsx
+ ```tsx
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1d33382 and bdae23a.
Files selected for processing (4)
  • contributing/Basic/Feature-Development.md (5 hunks)
  • contributing/Basic/Feature-Development.zh-CN.md (4 hunks)
  • contributing/Basic/Intro.md (2 hunks)
  • contributing/Basic/Intro.zh-CN.md (1 hunks)
Additional Context Used
Markdownlint (9)
contributing/Basic/Feature-Development.md (4)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


522: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Feature-Development.zh-CN.md (3)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Intro.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

contributing/Basic/Intro.zh-CN.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

Additional comments not posted (5)
contributing/Basic/Feature-Development.md (5)

Line range hint 14-27: The updates to the database schema and the addition of the sessionGroups table are well-documented and clear.


Line range hint 122-179: The implementation details for the SessionGroupModel and SessionService are clear and adhere to good coding practices.


Line range hint 179-354: The updates to the frontend data flow and store implementation are comprehensive and provide a good example of effective state management.


Line range hint 354-573: The UI implementation and action binding in the CreateGroupModal component are correctly done and well-documented.


Line range hint 573-709: The data migration strategy is comprehensive, covering both configuration files and database migrations. The implementation is well-documented.

@@ -1,22 +1,26 @@
# Technical Development Getting Started Guide

Welcome to the LobeChat technical development getting started guide. LobeChat is an AI conversation application built on the Next.js framework, which integrates a series of technology stacks to achieve diverse functions and features. This guide will provide a detailed introduction to the main technical components of LobeChat and how to configure and use these technologies in your development environment.
Welcome to the LobeChat Technical Development Getting Started Guide. LobeChat is an AI conversation application built on the Next.js framework, incorporating a range of technology stacks to achieve diverse functionalities and features. This guide will detail the main technical components of LobeChat and how to configure and use these technologies in your development environment.

#### TOC
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust heading levels for consistency.

- #### TOC
+ ## TOC

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
#### TOC
## TOC

@@ -119,7 +119,7 @@ export class LocalDB extends Dexie {

![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alternative text to images for accessibility.

- ![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (5)
contributing/Basic/Intro.zh-CN.md (1)

Line range hint 5-5: Adjust the heading level for consistency.

- #### TOC
+ ## TOC
contributing/Basic/Feature-Development.zh-CN.md (2)

Line range hint 204-204: Correct the adverbial modifier in the text.

- ๅˆ›ๅปบๆ–ฐ็š„ไผš่ฏ็ป„
+ ๅˆ›ๅปบๆ–ฐๅœฐไผš่ฏ็ป„

- ๆทปๅŠ ๆ–ฐ็š„ไผš่ฏ็ป„ๅŽ
+ ๆทปๅŠ ๆ–ฐๅœฐไผš่ฏ็ป„ๅŽ

- ็Šถๆ€ไธŽๆœ€ๆ–ฐ็š„ไผš่ฏๆ•ฐๆฎๅŒๆญฅ
+ ็Šถๆ€ไธŽๆœ€ๆ–ฐๅœฐไผš่ฏๆ•ฐๆฎๅŒๆญฅ

- ๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎš็š„ไผš่ฏ
+ ๅŒๆ—ถๆŸฅ่ฏข้ป˜่ฎคๅ’Œๅ›บๅฎšๅœฐไผš่ฏ

Also applies to: 226-226, 268-268, 319-319


Line range hint 391-391: Specify the language for code blocks.

- ```tsx
+ ```tsx
contributing/Basic/Feature-Development.md (2)

Line range hint 465-465: Consider replacing "very simple" with "straightforward" for a more professional tone.

- ...en that the migration implementation is very simple. However, it is important to ensure the...
+ ...en that the migration implementation is straightforward. However, it is important to ensure the...

Line range hint 391-391: Specify the language for code blocks to enable syntax highlighting.

- ```ts
+ ```typescript

Also applies to: 522-522

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bdae23a and 1159085.
Files selected for processing (4)
  • contributing/Basic/Feature-Development.md (5 hunks)
  • contributing/Basic/Feature-Development.zh-CN.md (4 hunks)
  • contributing/Basic/Intro.md (2 hunks)
  • contributing/Basic/Intro.zh-CN.md (1 hunks)
Additional Context Used
Markdownlint (9)
contributing/Basic/Feature-Development.md (4)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


522: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Feature-Development.zh-CN.md (3)

70: null
Blank line inside blockquote


391: null
Fenced code blocks should have a language specified


120: null
Images should have alternate text (alt text)

contributing/Basic/Intro.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

contributing/Basic/Intro.zh-CN.md (1)

5: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

Additional comments not posted (3)
contributing/Basic/Intro.md (1)

5-5: Adjust the heading level for consistency.

- #### TOC
+ ## TOC

Likely invalid or redundant comment.

contributing/Basic/Feature-Development.zh-CN.md (1)

120-120: Add alternative text to images for accessibility.

- ![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Likely invalid or redundant comment.

contributing/Basic/Feature-Development.md (1)

575-575: Consider rephrasing "exactly the same" to "identically" for conciseness.

- ... complete exported data can be restored exactly the same on other devices.  The core implementat...
+ ... complete exported data can be restored identically on other devices.  The core implementat...

Likely invalid or redundant comment.

Comment on lines +7 to +10
1. [Data Model / Database Definition](#1-data-model--database-definition)
2. [Service Implementation / Model Implementation](#2-service-implementation--model-implementation)
3. [Frontend Data Flow Store Implementation](#3-frontend-data-flow-store-implementation)
4. [UI Implementation and Action Binding](#4-ui-implementation-and-action-binding)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update internal links to match the new section headers.

- 1. [Data Model / Database Definition](#1-data-model--database-definition)
- 2. [Service Implementation / Model Implementation](#2-service-implementation--model-implementation)
- 3. [Frontend Data Flow Store Implementation](#3-frontend-data-flow-store-implementation)
- 4. [UI Implementation and Action Binding](#4-ui-implementation-and-action-binding)
+ 1. [Database Section](#1-database-section)
+ 2. [Model and Service Section](#2-model-and-service-section)
+ 3. [Store Action Section](#3-store-action-section)
+ 4. [UI Section](#4-ui-section)

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
1. [Data Model / Database Definition](#1-data-model--database-definition)
2. [Service Implementation / Model Implementation](#2-service-implementation--model-implementation)
3. [Frontend Data Flow Store Implementation](#3-frontend-data-flow-store-implementation)
4. [UI Implementation and Action Binding](#4-ui-implementation-and-action-binding)
1. [Database Section](#1-database-section)
2. [Model and Service Section](#2-model-and-service-section)
3. [Store Action Section](#3-store-action-section)
4. [UI Section](#4-ui-section)

@@ -119,7 +119,7 @@ As a result, you can now view the `sessionGroups` table in the `LOBE_CHAT_DB` in

![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alternate text to the image for accessibility.

- ![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
![](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)
+ ![Session Groups Table](https://github.com/lobehub/lobe-chat/assets/28616219/aea50f66-4060-4a32-88c8-b3c672d05be8)

Comment on lines 79 to 81
> \[!IMPORTANT]\
> ๅฆ‚ๆžœไฝฟ็”จ`npm`ๅฎ‰่ฃ…ไพ่ต–๏ผŒ่ฏทๅœจๆไบคไปฃ็ ๅ‰่ฟ่กŒ`npm run stylelint-config-recommended@13.0.0`๏ผŒ่ฟ™ๆ ทๅฏไปฅ้ฟๅ…ๅ‡บ็Žฐ`Could not find "stylelint-config-recommended"`้”™่ฏฏ

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the important note for better understanding.

- > ๅฆ‚ๆžœไฝฟ็”จ`npm`ๅฎ‰่ฃ…ไพ่ต–๏ผŒ่ฏทๅœจๆไบคไปฃ็ ๅ‰่ฟ่กŒ`npm run stylelint-config-recommended@13.0.0`๏ผŒ่ฟ™ๆ ทๅฏไปฅ้ฟๅ…ๅ‡บ็Žฐ`Could not find "stylelint-config-recommended"`้”™่ฏฏ
+ > \[!IMPORTANT] ๅฆ‚ๆžœไฝ ไฝฟ็”จ `npm` ๅฎ‰่ฃ…ไพ่ต–๏ผŒ่ฏทๅœจๆไบคไปฃ็ ๅ‰่ฟ่กŒ `npm run stylelint-config-recommended@13.0.0`ใ€‚่ฟ™ๆ ทๅฏไปฅ้ฟๅ…ๅ‡บ็Žฐๆ‰พไธๅˆฐ `stylelint-config-recommended` ็š„้”™่ฏฏใ€‚

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
> \[!IMPORTANT]\
> ๅฆ‚ๆžœไฝฟ็”จ`npm`ๅฎ‰่ฃ…ไพ่ต–๏ผŒ่ฏทๅœจๆไบคไปฃ็ ๅ‰่ฟ่กŒ`npm run stylelint-config-recommended@13.0.0`๏ผŒ่ฟ™ๆ ทๅฏไปฅ้ฟๅ…ๅ‡บ็Žฐ`Could not find "stylelint-config-recommended"`้”™่ฏฏ
> \[!IMPORTANT] ๅฆ‚ๆžœไฝ ไฝฟ็”จ `npm` ๅฎ‰่ฃ…ไพ่ต–๏ผŒ่ฏทๅœจๆไบคไปฃ็ ๅ‰่ฟ่กŒ `npm run stylelint-config-recommended@13.0.0`ใ€‚่ฟ™ๆ ทๅฏไปฅ้ฟๅ…ๅ‡บ็Žฐๆ‰พไธๅˆฐ `stylelint-config-recommended` ็š„้”™่ฏฏใ€‚

Comment on lines 79 to 81
> \[!IMPORTANT]\
> If you are using `npm` to install dependencies, please run `npm run stylelint-config-recommended@13.0.0` before committing your code to avoid the `Could not find "stylelint-config-recommended"` error.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the important note for better understanding.

- > If you are using `npm` to install dependencies, please run `npm run stylelint-config-recommended@13.0.0` before committing your code to avoid the `Could not find "stylelint-config-recommended"` error.
+ > \[!IMPORTANT] If you use `npm` to install dependencies, ensure you run `npm run stylelint-config-recommended@13.0.0` before committing your code to avoid the error `Could not find "stylelint-config-recommended"`.

Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
> \[!IMPORTANT]\
> If you are using `npm` to install dependencies, please run `npm run stylelint-config-recommended@13.0.0` before committing your code to avoid the `Could not find "stylelint-config-recommended"` error.
> \[!IMPORTANT] If you use `npm` to install dependencies, ensure you run `npm run stylelint-config-recommended@13.0.0` before committing your code to avoid the error `Could not find "stylelint-config-recommended"`.

@RubuJam RubuJam requested a review from arvinxx May 27, 2024 04:43
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@arvinxx arvinxx merged commit 729a977 into lobehub:main May 27, 2024
4 of 5 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @RubuJam โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

@RubuJam RubuJam deleted the Intro branch May 27, 2024 14:27
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.162.2 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
* ๐Ÿ“ docs: update docs

* ๐Ÿ“ docs: update docs

* ๐Ÿ“ docs: update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants