Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ’„ style: improve PWA install guide #2617

Merged
merged 7 commits into from
May 23, 2024
Merged

๐Ÿ’„ style: improve PWA install guide #2617

merged 7 commits into from
May 23, 2024

Conversation

canisminor1990
Copy link
Member

@canisminor1990 canisminor1990 commented May 23, 2024 •
edited by arvinxx
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

ref: https://github.com/khmyznikov/pwa-install

ๅขžๅŠ ้ž chrome ไธ‹ pwa ๅฎ‰่ฃ…ๆ•™็จ‹

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-community โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback May 23, 2024 2:37pm

@lobehubbot
Copy link
Member

๐Ÿ‘ @canisminor1990

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.56%. Comparing base (b287b0a) to head (0b838f3).
Report is 1103 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/platform.ts 93.93% 2 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
+ Coverage   93.54%   93.56%   +0.01%     
==========================================
  Files         344      346       +2     
  Lines       20287    20392     +105     
  Branches     1548     1561      +13     
==========================================
+ Hits        18978    19080     +102     
- Misses       1309     1312       +3

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title โœจ feat: Update PWA install ๐Ÿ’„ style: improve PWA install guide May 23, 2024
@arvinxx arvinxx merged commit 7fee545 into main May 23, 2024
10 checks passed
@arvinxx arvinxx deleted the feat/pwa-install branch May 23, 2024 15:59
@lobehubbot
Copy link
Member

โค๏ธ Great PR @canisminor1990 โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request May 23, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v0.161.11 [skip ci]
ce85cc6 
### [Version 0.161.11](v0.161.10...v0.161.11)
<sup>Released on **2024-05-23**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Improve PWA install guide.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Improve PWA install guide, closes [#2617](#2617) ([7fee545](7fee545))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.161.11 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 23, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.41.6 [skip ci]
efdd7a8 
### [Version&nbsp;1.41.6](v1.41.5...v1.41.6)
<sup>Released on **2024-05-23**</sup>

#### โ™ป Code Refactoring

- **misc**: Refactor the home redirect implement.

#### ๐Ÿ’„ Styles

- **misc**: Improve PWA install guide.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor the home redirect implement, closes [lobehub#2626](https://github.com/bentwnghk/lobe-chat/issues/2626) ([ab4216e](ab4216e))

#### Styles

* **misc**: Improve PWA install guide, closes [lobehub#2617](https://github.com/bentwnghk/lobe-chat/issues/2617) ([7fee545](7fee545))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@canisminor1990 @ipoly
๐Ÿ’„ style: improve PWA install guide (lobehub#2617)
08fa927 
* โœจ feat: Update PWA install

* โœจ feat: Update usePlatform

* โœจ feat: Update isSonomaOrLaterSafari

* ๐Ÿ› fix: Fix isSonomaOrLaterSafari

* ๐Ÿ› fix: Fix isSupportInstallPWA

* โœ… test: Add test

* โœ… test: Add isSonomaOrLaterSafari test
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@semantic-release-bot @ipoly
๐Ÿ”– chore(release): v0.161.11 [skip ci]
b6dfcd9 
### [Version&nbsp;0.161.11](lobehub/lobe-chat@v0.161.10...v0.161.11)
<sup>Released on **2024-05-23**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Improve PWA install guide.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Improve PWA install guide, closes [lobehub#2617](lobehub#2617) ([7fee545](lobehub@7fee545))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canisminor1990 @lobehubbot @arvinxx