Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: login button not show on user panel #2496

Merged
merged 3 commits into from
May 14, 2024

Conversation

cy948
Copy link
Contributor

@cy948 cy948 commented May 14, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  • 🐛 src/features/User/UserPanel/PanelContent.tsx:改为从 userStore 中读取 enableAuth ,判断是否显示登陆 button;
  • 🐛 src/features/User/UserPanel/PanelContent.tsx:handleSignOut 方法中添加了判断,不将 nextauth 用户重定向到 Clerk 登陆页面;
  • src/features/User/__tests__/PanelContent.test.tsx:同步更新 mock 中的 enableAuth

📝 补充信息 | Additional Information

  • 💡目前启用 Clerk 与 NextAuth 并登陆后才会在左上角模态框中显示“设置”按钮。

Copy link

vercel bot commented May 14, 2024

@cy948 is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @cy948

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.23%. Comparing base (465dbfc) to head (5cfa71e).
Report is 6 commits behind head on main.

Files Patch % Lines
src/features/User/UserPanel/PanelContent.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
- Coverage   93.24%   93.23%   -0.02%     
==========================================
  Files         323      323              
  Lines       19466    19522      +56     
  Branches     2290     1458     -832     
==========================================
+ Hits        18151    18201      +50     
- Misses       1315     1321       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:41pm

@arvinxx arvinxx merged commit 39637fb into lobehub:main May 14, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @cy948 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request May 14, 2024
### [Version 0.159.6](v0.159.5...v0.159.6)
<sup>Released on **2024-05-14**</sup>

#### 🐛 Bug Fixes

- **misc**: Login button not show on user panel.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Login button not show on user panel, closes [#2496](#2496) ([39637fb](39637fb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.159.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
* 🐛 fix: show login button when enable nextauth

* 🐛 fix: wrong navigate after logout
TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
### [Version&nbsp;0.159.6](lobehub/lobe-chat@v0.159.5...v0.159.6)
<sup>Released on **2024-05-14**</sup>

#### 🐛 Bug Fixes

- **misc**: Login button not show on user panel.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Login button not show on user panel, closes [lobehub#2496](lobehub#2496) ([39637fb](lobehub@39637fb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 15, 2024
### [Version&nbsp;1.39.2](v1.39.1...v1.39.2)
<sup>Released on **2024-05-15**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix agent config on page init, fix retry issue when hide page, login button not show on user panel, refresh model config form & mobile footer button lost.

#### 💄 Styles

- **misc**: Add GPT-4o model, fix scroll and expand, update perplexity models, updates 01.AI model list.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix agent config on page init, closes [lobehub#2506](https://github.com/bentwnghk/lobe-chat/issues/2506) ([90e742d](90e742d))
* **misc**: Fix retry issue when hide page, closes [lobehub#2503](https://github.com/bentwnghk/lobe-chat/issues/2503) ([24489bc](24489bc))
* **misc**: Login button not show on user panel, closes [lobehub#2496](https://github.com/bentwnghk/lobe-chat/issues/2496) ([39637fb](39637fb))
* **misc**: Refresh model config form & mobile footer button lost, closes [lobehub#2318](https://github.com/bentwnghk/lobe-chat/issues/2318) [lobehub#2319](https://github.com/bentwnghk/lobe-chat/issues/2319) [lobehub#1811](https://github.com/bentwnghk/lobe-chat/issues/1811) ([eadcefc](eadcefc))

#### Styles

* **misc**: Add GPT-4o model, closes [lobehub#2481](https://github.com/bentwnghk/lobe-chat/issues/2481) ([ae6a03f](ae6a03f))
* **misc**: Fix scroll and expand, closes [lobehub#2470](https://github.com/bentwnghk/lobe-chat/issues/2470) ([8b1202a](8b1202a))
* **misc**: Update perplexity models, closes [lobehub#2469](https://github.com/bentwnghk/lobe-chat/issues/2469) ([488cde7](488cde7))
* **misc**: Updates 01.AI model list, closes [lobehub#2471](https://github.com/bentwnghk/lobe-chat/issues/2471) ([f28711a](f28711a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@cy948 cy948 deleted the fix/nextauth-model branch June 18, 2024 16:34
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
* 🐛 fix: show login button when enable nextauth

* 🐛 fix: wrong navigate after logout
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;0.159.6](lobehub/lobe-chat@v0.159.5...v0.159.6)
<sup>Released on **2024-05-14**</sup>

#### 🐛 Bug Fixes

- **misc**: Login button not show on user panel.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Login button not show on user panel, closes [lobehub#2496](lobehub#2496) ([39637fb](lobehub@39637fb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants