-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
โจ feat: Add Settings Intercepting Routes #2346
Conversation
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
๐ @canisminor1990 Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.02%
==========================================
Files 296 297 +1
Lines 16872 16928 +56
Branches 1948 1218 -730
==========================================
+ Hits 15670 15726 +56
Misses 1202 1202 โ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
็ๅฎไบ๏ผๆๅๆตไธๅ่ฝ
src/app/(main)/chat/(desktop)/features/SideBar/SystemRole/index.tsx
Outdated
Show resolved
Hide resolved
ๅค็ฐๆนๅผ๏ผๅผไธไธช่ชๅฎไนๅฉๆ๏ผ็ถๅๆๅผ่ฎพ็ฝฎ bug.mp4 |
ๆชๅพๅๅฐฑ่ชๅจๅ ณ้ญไบ๏ผๆไบๅ่ฝฆ้ฎ๏ผ๏ผ default.mp4 |
0bd416a
to
dac4aaa
Compare
่ฟๆฏไธช antd ็ triggle ๅง๏ผ |
|
โค๏ธ Great PR @canisminor1990 โค๏ธ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 0.153.0](v0.152.12...v0.153.0) <sup>Released on **2024-05-04**</sup> #### โจ Features - **misc**: Add Settings Intercepting Routes. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add Settings Intercepting Routes, closes [#2346](#2346) ([29b6442](29b6442)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
๐ This PR is included in version 0.153.0 ๐ The release is available on: Your semantic-release bot ๐ฆ๐ |
## [Version 1.33.0](v1.32.2...v1.33.0) <sup>Released on **2024-05-04**</sup> #### โจ Features - **misc**: Add Settings Intercepting Routes. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add Settings Intercepting Routes, closes [lobehub#2346](https://github.com/bentwnghk/lobe-chat/issues/2346) ([29b6442](29b6442)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
* โป๏ธ refactor: Refactor Setting Layout * โป๏ธ refactor: Update useQueryRoute and add test * โ test: Update test * โจ feat: Add Settings Intercepting Routes * โป๏ธ refactor: Refactor Setting Layout * โป๏ธ refactor: Update useQueryRoute and add test * โ test: Update test * ๐ fix: Fix i18n * ๐ style: Fix style * ๐ fix: Fix review problem * ๐ fix: Fix review problem * โ test: Add useInterceptingRoutes.test * ๐ fix: Fix config * ๐ fix: Fix some merge problem * ๐ fix: Fix modal layout * ๐ fix: Fix cubox * ๐ fix: Fix cubox * โ test: Fix test * ๐ fix: Fix redirect * ๐ fix: Fix review problem --------- Co-authored-by: Arvin Xu <arvinx@foxmail.com>
## [Version 0.153.0](lobehub/lobe-chat@v0.152.12...v0.153.0) <sup>Released on **2024-05-04**</sup> #### โจ Features - **misc**: Add Settings Intercepting Routes. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add Settings Intercepting Routes, closes [lobehub#2346](lobehub#2346) ([29b6442](lobehub@29b6442)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
* โป๏ธ refactor: Refactor Setting Layout * โป๏ธ refactor: Update useQueryRoute and add test * โ test: Update test * โจ feat: Add Settings Intercepting Routes * โป๏ธ refactor: Refactor Setting Layout * โป๏ธ refactor: Update useQueryRoute and add test * โ test: Update test * ๐ fix: Fix i18n * ๐ style: Fix style * ๐ fix: Fix review problem * ๐ fix: Fix review problem * โ test: Add useInterceptingRoutes.test * ๐ fix: Fix config * ๐ fix: Fix some merge problem * ๐ fix: Fix modal layout * ๐ fix: Fix cubox * ๐ fix: Fix cubox * โ test: Fix test * ๐ fix: Fix redirect * ๐ fix: Fix review problem --------- Co-authored-by: Arvin Xu <arvinx@foxmail.com>
## [Version 0.153.0](lobehub/lobe-chat@v0.152.12...v0.153.0) <sup>Released on **2024-05-04**</sup> #### โจ Features - **misc**: Add Settings Intercepting Routes. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add Settings Intercepting Routes, closes [lobehub#2346](lobehub#2346) ([29b6442](lobehub@29b6442)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
่ฎพ็ฝฎๅผน็ชๆฆๆช่ทฏ็ฑๆนๅจ่ฏดๆ
็ฎๆ
ๅผน็ช
ๅผๅฏ่ฎพ็ฝฎ้ขๆฟๅ จๅฑ่ฎพ็ฝฎๅไผ่ฏ่ฎพ็ฝฎ (ๅ้กต้ข๏ผ้กต้ข
ๅฑ็คบ (ๅค้กต้ข)่ๆฏ๏ผ็ฎๅ้็็็คพๅบ้ฎ้ข๏ผ
ๆฆๆช่ทฏ็ฑๆ ๆณๅๆง๏ผไธ่ฝ่ช็ฑๅฎไนไปไนๆ ๅตไธๅผๅฏๆฆๆชไปไนๆ ๅตไธๅ ณ้ญๆฆๆช๏ผ็ช็ ด้ๅถ็ๆนๅผๅชๆ้่ฟ redirect ็กฌๅทๆฐ
https://www.reddit.com/r/nextjs/comments/174m3xf/how_to_stop_intercepting_routes_for_some_specific/
Warning
ไฝๆต่ฏๅๅ็ฐๅจ ios ่ฎพๅซไธๅๅบๅพๆ ข๏ผๆๆถๅ็่ณๆ ๆณๅๅบ
่ฎพ่ฎกๆ่ทฏ
ๅฝๅ็่ฎพ่ฎกๆ่ทฏๆฏ้่ฟ่ทฏ็ฑ่ฟ่กๅๆง๏ผไพๅฆๆณๅฎ็ฐ
/settings
ๅๆง/settings/modal?tab=common
/settings/common
ไผ่ฏ่ฎพ็ฝฎๅ็
/chat/settings/modal
/chat/settings
ๆไปถ็ปๆ็คบๆ
Fallback ่ทฏ็ฑ็คบๆ:
app/(main)/settings/modal/page.tsx
ๅทฅๅ ท hook
็ฑไบๆฆๆชๅคๆญๆกไปถๆฏ่พๅคๆ๏ผๅ ่ฃ ไธบไธคไธช hook ๆนๆณๆนไพฟไฝฟ็จ
ๆๅผ่ฎพ็ฝฎ้ขๆฟ๏ผ
useOpenSettings
ๆๅผ่ง่ฒ่ฎพ็ฝฎ้ขๆฟ๏ผ
useOpenChatSettings