Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ perf: Refactor Chat Layout to improve performance #2339

Merged
merged 18 commits into from
May 8, 2024

Conversation

canisminor1990
Copy link
Member

@canisminor1990 canisminor1990 commented May 2, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

refs: #2295

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 0:13am

@lobehubbot
Copy link
Member

👍 @canisminor1990

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@arvinxx
Copy link
Contributor

arvinxx commented May 2, 2024

把重构拆细,既然只重构 Chat Layout ,不能包含其他不相关的部分

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Break down the refactoring. Since only Chat Layout is refactored, other irrelevant parts cannot be included.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (12c62a0) to head (d987e8b).
Report is 1236 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2339   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         302      302           
  Lines       17574    17585   +11     
  Branches     2029     2029           
=======================================
+ Hits        16327    16338   +11     
  Misses       1247     1247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canisminor1990
Copy link
Member Author

把重构拆细,既然只重构 Chat Layout ,不能包含其他不相关的部分

done

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Break down the refactoring. Since only Chat Layout is refactored, other irrelevant parts cannot be included.

done

Base automatically changed from refactor/setting-layout to main May 2, 2024 15:08
@arvinxx
Copy link
Contributor

arvinxx commented May 3, 2024

ci 挂了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


ci is down

@arvinxx

This comment was marked as resolved.

@canisminor1990

This comment was marked as resolved.

@arvinxx

This comment was marked as resolved.

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@canisminor1990 How to solve the new layout mentioned before?

@canisminor1990

This comment was marked as resolved.

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@canisminor1990 How to solve the new layout mentioned before?

@conversation (Layout 1)
@flow (Layout 2)

The layout at this level can control which layout to switch

@canisminor1990

This comment was marked as resolved.

@lobehubbot

This comment was marked as resolved.

@arvinxx arvinxx changed the title ♻️ refactor: Refactor Chat Layout ⚡️ perf: Refactor Chat Layout to improve performance May 8, 2024
@arvinxx arvinxx merged commit 2aeaedc into main May 8, 2024
10 checks passed
@arvinxx arvinxx deleted the refactor/chat-layout branch May 8, 2024 12:44
@lobehubbot
Copy link
Member

❤️ Great PR @canisminor1990 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.155.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
* ♻️ refactor: Refactor Chat Layout

* ✅ test: Fix test

* 🐛 fix: Fix ci

* 🔧 chore: Rename workspace

* 🔧 chore: Revert sync style

* 🐛 fix: Fix review problem

* 💄 style: Fix style

* 🔧 chore: Revert useInterceptingRoutes

* 🐛 fix: Fix review problem

* 💄 style: Remove animation

* 🐛 fix: Fix panel

* 🐛 fix: Fix mobile style

* 🐛 fix: Fix Workspace Modal

* 🐛 fix: FIx ios keyboard scroll back

* 🐛 fix: Fix lint

* 🔧 chore: prepare to rebase

* 🐛 fix: Fix PWA

* 🐛 fix: Fix safearea
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
* ♻️ refactor: Refactor Chat Layout

* ✅ test: Fix test

* 🐛 fix: Fix ci

* 🔧 chore: Rename workspace

* 🔧 chore: Revert sync style

* 🐛 fix: Fix review problem

* 💄 style: Fix style

* 🔧 chore: Revert useInterceptingRoutes

* 🐛 fix: Fix review problem

* 💄 style: Remove animation

* 🐛 fix: Fix panel

* 🐛 fix: Fix mobile style

* 🐛 fix: Fix Workspace Modal

* 🐛 fix: FIx ios keyboard scroll back

* 🐛 fix: Fix lint

* 🔧 chore: prepare to rebase

* 🐛 fix: Fix PWA

* 🐛 fix: Fix safearea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants