♻️ refactor: refactor feature flags store to server config store #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
👍 @arvinxx Thank you for raising your pull request and contributing to our Community |
arvinxx
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 92.53% 92.57% +0.03%
==========================================
Files 279 282 +3
Lines 15981 16061 +80
Branches 1152 1865 +713
==========================================
+ Hits 14788 14868 +80
Misses 1193 1193 ☔ View full report in Codecov by Sentry. |
|
❤️ Great PR @arvinxx ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2024
### [Version 0.150.9](v0.150.8...v0.150.9) <sup>Released on **2024-04-28**</sup> #### ♻ Code Refactoring - **misc**: Refactor feature flags store to server config store. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Refactor feature flags store to server config store, closes [#2263](#2263) ([2e991d7](2e991d7)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 0.150.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to bentwnghk/lobe-chat
that referenced
this pull request
Apr 28, 2024
### [Version 1.30.5](v1.30.4...v1.30.5) <sup>Released on **2024-04-28**</sup> #### ♻ Code Refactoring - **misc**: Refactor feature flags store to server config store. #### 🐛 Bug Fixes - **misc**: Suport to fetch model list on client. #### 💄 Styles - **ollama**: Phi3 Instruct models and its model icons. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Refactor feature flags store to server config store, closes [lobehub#2263](https://github.com/bentwnghk/lobe-chat/issues/2263) ([2e991d7](2e991d7)) #### What's fixed * **misc**: Suport to fetch model list on client, closes [lobehub#2252](https://github.com/bentwnghk/lobe-chat/issues/2252) ([76310a8](76310a8)) #### Styles * **ollama**: Phi3 Instruct models and its model icons, closes [lobehub#2254](https://github.com/bentwnghk/lobe-chat/issues/2254) ([c9b55cc](c9b55cc)) </details> <div align="right"> [](#readme-top) </div>
TheNameIsNigel
pushed a commit
to TheNameIsNigel/lobe-chat
that referenced
this pull request
May 15, 2024
…ehub#2263) * 🚚 refactor: rename featureFlag store to serverConfig store * 🚚 refactor: use serverConfigSelectors to replace commonSelectors * 🎨 chore: clean code
TheNameIsNigel
pushed a commit
to TheNameIsNigel/lobe-chat
that referenced
this pull request
May 15, 2024
### [Version 0.150.9](lobehub/lobe-chat@v0.150.8...v0.150.9) <sup>Released on **2024-04-28**</sup> #### ♻ Code Refactoring - **misc**: Refactor feature flags store to server config store. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Refactor feature flags store to server config store, closes [lobehub#2263](lobehub#2263) ([2e991d7](lobehub@2e991d7)) </details> <div align="right"> [](#readme-top) </div>
ipoly
pushed a commit
to ipoly/lobe-chat
that referenced
this pull request
Jul 29, 2024
…ehub#2263) * 🚚 refactor: rename featureFlag store to serverConfig store * 🚚 refactor: use serverConfigSelectors to replace commonSelectors * 🎨 chore: clean code
ipoly
pushed a commit
to ipoly/lobe-chat
that referenced
this pull request
Jul 29, 2024
### [Version 0.150.9](lobehub/lobe-chat@v0.150.8...v0.150.9) <sup>Released on **2024-04-28**</sup> #### ♻ Code Refactoring - **misc**: Refactor feature flags store to server config store. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Refactor feature flags store to server config store, closes [lobehub#2263](lobehub#2263) ([2e991d7](lobehub@2e991d7)) </details> <div align="right"> [](#readme-top) </div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
将原本 globalStore 中的 serverConfig 挪到 feature flags store 中，用于聚合所有的服务端变量
📝 补充信息 | Additional Information