Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: fix non-https crypto.subtile missing error #1238

Merged
merged 6 commits into from
Feb 6, 2024
Merged

🐛 fix: fix non-https crypto.subtile missing error #1238

merged 6 commits into from
Feb 6, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Feb 6, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  1. 修复非 HTTP 模式下,因 crypto.subtle 缺失造成的报错问题。 close 最新版本发送消息后一直在等待,没有回应 #1239 ,close [Bug] Uncaught TypeError: Cannot read properties of undefined #1227
  2. 修复自定义模型问题, close [Bug] GPT4默认模型呢?为什么自定义添加了也没有? #1236
  3. 修正切换语言时存在停顿无法及时响应的问题

📝 补充信息 | Additional Information

HTTP 协议下不使用 jwt 加密,直接 base64 传输前端 token

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 7:16am

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (b8118a2) 86.82% compared to head (9a901a2) 86.86%.

Files Patch % Lines
src/utils/jwt.ts 45.94% 20 Missing ⚠️
src/app/api/errorResponse.ts 88.88% 1 Missing ⚠️
src/services/_auth.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   86.82%   86.86%   +0.04%     
==========================================
  Files         211      212       +1     
  Lines       10381    10395      +14     
  Branches     1138     1135       -3     
==========================================
+ Hits         9013     9030      +17     
+ Misses       1368     1365       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title 🐛 fix: fix custom model missing and auth bug 🐛 fix: fix non-https crypto.subtile missing error Feb 6, 2024
@arvinxx arvinxx merged commit 1750d0b into main Feb 6, 2024
9 of 10 checks passed
@arvinxx arvinxx deleted the fix/bug branch February 6, 2024 07:20
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
### [Version 0.123.3](v0.123.2...v0.123.3)
<sup>Released on **2024-02-06**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix non-https `crypto.subtile` missing error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix non-https `crypto.subtile` missing error, closes [#1238](#1238) ([1750d0b](1750d0b))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.123.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lengxuange1
Copy link

docker是否更新?我镜像还未找到最新版本,目前仍有这个问题

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is docker updated? My mirror has not found the latest version yet, and I still have this problem.

gijigae pushed a commit to gijigae/lobe-chat that referenced this pull request Feb 6, 2024
### [Version&nbsp;0.123.3](lobehub/lobe-chat@v0.123.2...v0.123.3)
<sup>Released on **2024-02-06**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix non-https `crypto.subtile` missing error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix non-https `crypto.subtile` missing error, closes [lobehub#1238](lobehub#1238) ([1750d0b](lobehub@1750d0b))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Feb 6, 2024
## [Version&nbsp;1.6.0](v1.5.3...v1.6.0)
<sup>Released on **2024-02-06**</sup>

#### ✨ Features

- **misc**: Support Moonshot AI Provider.

#### 🐛 Bug Fixes

- **misc**: Fix non-https `crypto.subtile` missing error, fix rename.

#### 💄 Styles

- **misc**: Add moonshot i18n, improve clear topic tips, improve direction UX.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Support Moonshot AI Provider, closes [lobehub#1232](https://github.com/bentwnghk/lobe-chat/issues/1232) ([a6de202](a6de202))

#### What's fixed

* **misc**: Fix non-https `crypto.subtile` missing error, closes [lobehub#1238](https://github.com/bentwnghk/lobe-chat/issues/1238) ([1750d0b](1750d0b))
* **misc**: Fix rename ([c94391e](c94391e))

#### Styles

* **misc**: Add moonshot i18n, closes [lobehub#1251](https://github.com/bentwnghk/lobe-chat/issues/1251) ([4b6663b](4b6663b))
* **misc**: Improve clear topic tips, closes [lobehub#1247](https://github.com/bentwnghk/lobe-chat/issues/1247) ([2d133e9](2d133e9))
* **misc**: Improve direction UX, closes [lobehub#1169](https://github.com/bentwnghk/lobe-chat/issues/1169) ([e3929dc](e3929dc))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
miroshar-success added a commit to miroshar-success/OpenAI_Integraion_platform that referenced this pull request Apr 5, 2024
### [Version&nbsp;0.123.3](lobehub/lobe-chat@v0.123.2...v0.123.3)
<sup>Released on **2024-02-06**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix non-https `crypto.subtile` missing error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix non-https `crypto.subtile` missing error, closes [#1238](lobehub/lobe-chat#1238) ([1750d0b](lobehub/lobe-chat@1750d0b))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants