Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armenia is not supported #178

Open
antennaio opened this issue Oct 31, 2023 · 1 comment · May be fixed by #184
Open

Armenia is not supported #178

antennaio opened this issue Oct 31, 2023 · 1 comment · May be fixed by #184

Comments

@antennaio
Copy link

Summary

The ISO 3166 country code of Armenia is AM. Armenia is not included in the CountryExtended nor CountryExtendedExpanded enum. Please correct me if it is on purpose and Armenia is indeed an unsupported country.

Expected Behavior

The enums should include AM / ARMENIA as one of the possible values.

https://github.com/lob/lob-php/blob/main/lib/Model/CountryExtended.php
https://github.com/lob/lob-php/blob/main/lib/Model/CountryExtendedExpanded.php

Current Behavior

AM / ARMENIA is not a supported country.

Possible Solution

Add AM / ARMENIA as one of the supported countries.

Steps to Reproduce

  1. \OpenAPI\Client\Model\CountryExtended::from('AM')
  2. See exception: "AM" is not a valid backing value for enum OpenAPI\Client\Model\CountryExtended
alies-dev added a commit to InteractionDesignFoundation/lob-php that referenced this issue Jan 30, 2024
@alies-dev alies-dev linked a pull request Jan 30, 2024 that will close this issue
@alies-dev
Copy link

I have the same issue, created I PR: #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants