Support function calls as custom names (to stop false warnings) #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: * mocha-each style `forEach` prefix now does not have an error reported on its nested hooks, * additional custom names chained off describe/context can work, in line with how .only and .skip work, * the combination of the above, where there is a function call chained directly off describe/context.
This way is slightly more explicit and allows top-level to distinguish between the call of the custom function and the call of the function that's returned. For example, forEach([1, 2, 3]).describe fails the max-top-level-suites rule if it contained more than one nested suite. Updates tests to match the new setting names. Add more tests to guard against regressions (some of these were already supported, such as dotted properties, but not explicitly so).
Link to mocha-each as an example for custom naming. Add examples of the kinds of names that may be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call expressions can have a name when getting the node. Fixes #335
There might have been better ways to achieve this, but this looked like the most straightforward.