-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #246
Updates #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I’ve merged #245, so can you please rebase?
- npm: Update devDeps (coveralls, eslint-plugin-node, mocha, nyc) - Maintenance: Add `.ncurc.js` to prevent peerDep. updates on running local `npm-check-updates`
Cool, thanks! I've rebased! |
Oh--would you like an update for eslint 7 too? |
To make it easier for Github Actions, and as many other projects are dropping such support, you might want to drop end-of-lifed Node 8 support and just go to Node 10 (and add 14). I can add that to this PR if you like... |
Sounds good to me. However if we drop node 8 we should also require eslint > 7 as a peer dependency right? |
No need to require it as a peer dependency as eslint < 7 still works on Node 10-14. But if you didn't want to add older eslint versions to the Github Actions matrix to be fully sure that multiple eslint versions are still working with your tests, and you wanted to ensure no consumers could accidentally use the plugin without warning if using eslint < 7, then we could bump the peerDeps to eslint 7--however you like. |
You are absolutely right. |
Sure, SGTM. And as it is only a warning, people could technically use an earlier ESLint version if they wished. I'll add it now on top of the other fixes for ESLint just added. |
Added to #247. |
Builds on #245 .
.ncurc.js
to prevent peerDep. updates on running localnpm-check-updates