Add schemas for options (and remove for files which are using settings) #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want me to keep the schemas for settings, I can instead comment them out, but AFAICT, they are only usable with options, not
settings
.Note that I've had to comment out one test case in each of the two
valid-*-description
rules for this PR as the new schema causes some RegExp literals to fail on a couple properties (since JSON Schema can only specify JSON types and does not support indicating aRegExp
except as a string).