Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate whether rule is recommended #229

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Indicate whether rule is recommended #229

merged 1 commit into from
Feb 18, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Feb 17, 2020

Builds on #228

  • Indicate whether rule is recommended (also put into table along with info on whether "fixable")

@lo1tuma
Copy link
Owner

lo1tuma commented Feb 17, 2020

#228 has been merged, can you rebase and fix the failing test?

@brettz9
Copy link
Contributor Author

brettz9 commented Feb 17, 2020

Thanks for all the merges! I've rebased and fixed the doc test.

lo1tuma
lo1tuma approved these changes Feb 18, 2020
View reviewed changes
Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lo1tuma lo1tuma changed the title Recommended rules Indicate whether rule is recommended Feb 18, 2020
@lo1tuma lo1tuma merged commit c1f8049 into lo1tuma:master Feb 18, 2020
@brettz9 brettz9 deleted the recommended-rules branch February 18, 2020 14:32
This was referenced Mar 15, 2020
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo1tuma lo1tuma lo1tuma approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettz9 @lo1tuma