Fix max-top-level-suites to ignore generated suites

lo1tuma · Feb 18, 2020 · 2633908 · 2633908
1 parent 1c3a545
commit 2633908
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/lib/rules/max-top-level-suites.js b/lib/rules/max-top-level-suites.js
@@ -26,7 +26,6 @@ module.exports = {
         ]
     },
     create(context) {
-        const stack = [];
         const topLevelDescribes = [];
         const options = context.options[0] || {};
         const settings = context.settings;
@@ -41,17 +40,11 @@ module.exports = {
         return {
             CallExpression(node) {
                 if (astUtil.isDescribe(node, additionalSuiteNames(settings))) {
-                    stack.push(node);
-                }
-            },
+                    const scope = context.getScope();
 
-            'CallExpression:exit'(node) {
-                if (astUtil.isDescribe(node, additionalSuiteNames(settings))) {
-                    if (stack.length === 1) {
+                    if (scope.upper === null) {
                         topLevelDescribes.push(node);
                     }
-
-                    stack.pop(node);
                 }
             },
 

diff --git a/test/rules/max-top-level-suites.js b/test/rules/max-top-level-suites.js
@@ -53,7 +53,8 @@ ruleTester.run('max-top-level-suites', rules['max-top-level-suites'], {
                 }
             }
         },
-        'someOtherFunction();'
+        'someOtherFunction();',
+        'describe("top", function () {}); function foo() { describe("not necessarily top", function () {}); }'
     ],
 
     invalid: [