Update fa.yaml

[amirmohamadamini]

Minor grammatical corrections only.

Summary by CodeRabbit

• Documentation
  • Updated Persian language translations for trading actions.
  • Enhanced order details to display additional metadata including status, participant information, and timestamps.
  • Refined error message formatting for image processing notifications.

[coderabbitai]

Walkthrough

This pull request updates Persian language translations in the locale file, modifying verb forms for trading actions (sell/buy operations) and expanding the order details metadata block to include additional order information such as status, creator/buyer details, reputations, and timestamps.

Changes

Cohort / File(s)	Summary
Trading action translations locales/fa.yaml	Updated sell_sats and buy_sats verb forms to use infinitive constructions instead of noun forms for more grammatically appropriate Persian phrasing
Order detail metadata expansion locales/fa.yaml	Expanded order_detail block from minimal structure to comprehensive format including order IDs, status details, creator/buyer/seller information, reputations, timestamps, and related transaction hashes
Message formatting adjustment locales/fa.yaml	Adjusted image_processing_error message by adding terminal punctuation and normalizing formatting

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Single-file modification containing straightforward translation updates and locale string expansions with minimal logic density. Review focus should verify Persian language accuracy, YAML syntax validity, and consistent formatting across the updated entries.

Poem

🐰 ✨ A Persian phrase, refined with care,
Trading verbs now dance through the air,
Order details bloom, a fuller display,
Where timestamps and reputations hold sway,
One tiny file transformed, translations so fair!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title "Update fa.yaml" is extremely generic and lacks specificity about the nature of the changes. While it correctly identifies the file being modified, it provides no meaningful information about what is actually being updated or why. According to the changeset, the PR contains multiple types of updates including translation refinements (sell_sats, buy_sats), expanded order metadata structures, and punctuation adjustments. A developer scanning the commit history would have no way to understand these changes from the title alone, as "Update [filename]" is a non-descriptive pattern that could describe almost any modification to a YAML configuration file.	Consider revising the title to be more specific and descriptive. A better title would clearly indicate the main purpose of the changes, such as "Improve Persian translations and order metadata structure" or "Refine Persian translations and expand order details" to give reviewers and future maintainers immediate clarity about the changeset's content and intent.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac9def and b2c385a.

📒 Files selected for processing (1)

• locales/fa.yaml (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

locales/**/*.{yml,yaml}

📄 CodeRabbit inference engine (CLAUDE.md)

Store i18n message templates as YAML files under locales/ for multi-language support

Files:

• locales/fa.yaml

🔇 Additional comments (3)

locales/fa.yaml (3)

174-175: Verify the infinitive verb form changes are contextually appropriate.

The changes convert noun forms ("فروش ساتوشی‌ها" / "خرید ساتوشی") to infinitive forms ("فروختن ساتوشی" / "خریدن ساتوشی"). If these keys are used as action button labels in the UI, the infinitive forms are indeed more natural in Persian. However, confirm this change aligns with how the UI renders these labels (e.g., whether they're displayed as verbs or nouns in context).

---

176-221: Clarify the scope of the order_detail expansion.

The PR description states "Minor grammatical corrections only," but the order_detail block appears to be substantially expanded with comprehensive order metadata (creator, buyer, seller, reputations, successful trades, timestamps, invoice hashes, and secrets). This goes beyond grammatical corrections and represents a significant content change.

Confirm whether this expansion was intentional and intended as part of this PR, or if it should be addressed in a separate change.

---

665-665: Punctuation normalization is appropriate.

The addition of a period at the end of the image_processing_error message ensures proper Persian sentence punctuation and aligns with the PR objective of minor grammatical corrections.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[grunch]

LGTM