Enable voltage and current sensors for AFCv4 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustofg
force-pushed
the
fix-afcv4-volt-cur-sdr
branch
from
f05ae1c
to
f6e5654
Compare
Previously, the voltage and current sensors were disabled because it was causing the MCH to crash with a lot of 'AMC +12V Curr' assertion / deassertion messages and IPMB errors. The root cause for this behavior is not yet understood, but it is somewhat related to the voltage sensors SDR struct not been populated with the thresholds (they were all commented). I've updated all thresholds (voltages and currents) to reasonable defaults, but they might be wrong, so a more in depth study of the AFCv4 power rails should be conducted to obtain the correct values. It works for now, and the MCH doesn't crash, neither complain about out of range voltages or currents.
augustofg
force-pushed
the
fix-afcv4-volt-cur-sdr
branch
from
f6e5654
to
c0e6da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the voltage and current sensors were disabled because it was causing the MCH to crash with a lot of 'AMC +12V Curr' assertion / deassertion messages and IPMB errors. The root cause for this behavior is not yet understood, but it is somewhat related to the voltage sensors SDR struct not been populated with the thresholds (they were all commented). I've updated all thresholds (voltages and currents) to reasonable defaults, but they might be wrong, so a more in depth study of the AFCv4 power rails should be conducted to obtain the correct values.
It works for now, and the MCH doesn't crash, neither complain about out of range voltages or currents.