Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FRU reading / writing operations #197

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix FRU reading / writing operations #197

merged 1 commit into from
Jan 29, 2024

Conversation

gustavosr8
Copy link
Contributor

No description provided.

@gustavosr8 gustavosr8 marked this pull request as draft January 26, 2024 18:00
@gustavosr8 gustavosr8 force-pushed the fru-eeprom-write branch 2 times, most recently from 5e1d1d0 to 0c46366 Compare January 29, 2024 15:25
@gustavosr8 gustavosr8 marked this pull request as ready for review January 29, 2024 15:35
modules/at24mac.c Outdated Show resolved Hide resolved
modules/at24mac.c Outdated Show resolved Hide resolved
@augustofg
Copy link
Member

augustofg commented Jan 29, 2024

Also, please update the commit message to reflect the problem you fixed:

Fix FRU reading / writing operations

Add a non zero timeout value so FRU read operations fail less often,
fix FRU writing (at24mac) function to wait until the EEPROM is not
busy before proceeding to the next block write.

modules/at24mac.c Outdated Show resolved Hide resolved
@gustavosr8 gustavosr8 force-pushed the fru-eeprom-write branch 2 times, most recently from 4bf6820 to 7b323e1 Compare January 29, 2024 17:19
Add a non zero timeout value so FRU read operations fail less often,
fix FRU writing (at24mac) function to wait until the EEPROM is not
busy before proceeding to the next block write.
@augustofg augustofg changed the title Successfully write FRU records in at24mac eeprom Fix FRU reading / writing operations Jan 29, 2024
@augustofg
Copy link
Member

👍

@augustofg augustofg merged commit 3f659b9 into devel Jan 29, 2024
6 checks passed
@augustofg augustofg deleted the fru-eeprom-write branch January 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants