Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the real size of tx_len #172

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix the real size of tx_len #172

merged 1 commit into from
Oct 4, 2023

Conversation

gustavosr8
Copy link
Contributor

Since the first byte of page_buf is the address, the real written data is the number of written bytes minus one.

@gustavosr8 gustavosr8 linked an issue Aug 21, 2023 that may be closed by this pull request
@gustavosr8 gustavosr8 self-assigned this Aug 30, 2023
@gustavosr8 gustavosr8 added the bug label Aug 30, 2023
modules/at24mac.c Outdated Show resolved Hide resolved
@augustofg
Copy link
Member

Also, the commit title is a bit cryptic. Here is a clearer one: "Fix incorrect data write length [at24mac]"

@gustavosr8 gustavosr8 force-pushed the driver-ar24mac-fix branch 3 times, most recently from fae4bba to d2e0e8c Compare October 4, 2023 13:02
@augustofg
Copy link
Member

lenght -> length

Since the first byte of page_buf is the address, the real written data
is the number of written bytes minus one.
@augustofg augustofg merged commit 1d3c051 into devel Oct 4, 2023
5 checks passed
@augustofg augustofg deleted the driver-ar24mac-fix branch October 4, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong size of tx_len after write data on at24mac driver
2 participants