Remove incorrect use of sizeof() #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavosr8
force-pushed
the
solve-memory-issues
branch
from
c21a5a3
to
aeffe67
Compare
augustofg
requested changes
Jul 3, 2023
| @@ -80,7 +80,7 @@ IPMI_HANDLER(ipmi_oem_cmd_i2c_transfer, NETFN_CUSTOM_OEM, IPMI_OEM_CMD_I2C_TRANS | |||
|
|
|||
| if ( read_len > 0 ) { | |||
| read_data = pvPortMalloc( read_len ); | |||
| memset( read_data, read_len, 0 ); | |||
| memset( read_data, 0, read_len ); | |||
There was a problem hiding this comment.
You should apply this fix to other targets (afcv-bpm and afc-v4)
gustavosr8
force-pushed
the
solve-memory-issues
branch
3 times, most recently
from
70cfe8d
to
fcc3894
Compare
|
Ok, I would improve the commit message to reflect the changes: |
gustavosr8
force-pushed
the
solve-memory-issues
branch
from
fcc3894
to
df3d33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve memory issues #125 by correcting the use of the memset function and by changing sizeof(hpm_page) by PAYLOAD_HPM_PAGE_SIZE.