Open
Conversation
…on to fetch pre-signed url to view the file using idDocumentReadUrl query
…Level mutation to update user level
…lly for PRO upgrade requests
…tion is available.
…count Management Request doctype
…mer, address and bank account records when user request is approved
This was
linked to
issues
Feb 23, 2026
brh28
reviewed
Feb 23, 2026
Collaborator
brh28
left a comment
brh28
left a comment
There was a problem hiding this comment.
Reviewed the backend changes. Looks good, just a few small comments/questions
| address = frappe.get_doc({ | ||
| "doctype": "Address", | ||
| "address_title": req.address_title or req.full_name, | ||
| "address_type": "Billing", |
Collaborator
There was a problem hiding this comment.
@islandbitcoin The address the user enters is their business, correct? If so, perhaps this should be set to Shop or Current?
| req.approval_date = frappe.utils.now_datetime() | ||
| req.save() | ||
| # Enqueue ERP record creation in the background — keeps the approve response fast | ||
| if req.requested_level in ("TWO", "THREE"): |
Collaborator
There was a problem hiding this comment.
why is this the only task being queued?
Contributor
Author
There was a problem hiding this comment.
why is this the only task being queued?
All other steps must be synchronous because the approval cannot proceed without their results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.