Skip to content

Change types and interfaces for AccountUpgradeRequest#278

Merged
brh28 merged 6 commits intomainfrom
dev/refactor-acct-upgrade
Feb 19, 2026
Merged

Change types and interfaces for AccountUpgradeRequest#278
brh28 merged 6 commits intomainfrom
dev/refactor-acct-upgrade

Conversation

@brh28
Copy link
Contributor

@brh28 brh28 commented Feb 14, 2026

  • Creates GQL Inputs for Address and Bank Account, which map to ErpNext DocTypes
  • Splits BusinessUpgradeRequestInput into a ProUpgradeRequest & MerchantUpgradeRequest
  • Simplifies Validation logic using existing validator
  • Removes automatic upgrades for Pro
  • set terminalsRequested as an int (validation asserts max of 1)
  • updates return values with the request id so that it can be later queried/handled

@brh28
Copy link
Contributor Author

brh28 commented Feb 14, 2026

Note, Account Upgrade Request Doctype needs to be update in flash-frappe-admin. This PR has been successfully tested and creates the following sample:

Screenshot from 2026-02-13 20-51-30

@brh28 brh28 requested a review from islandbitcoin February 14, 2026 02:53
@islandbitcoin
Copy link
Contributor

looks like this needs a rebase

Copy link
Contributor

@islandbitcoin islandbitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@islandbitcoin
Copy link
Contributor

LGTM

@brh28 brh28 merged commit c7b39c0 into main Feb 19, 2026
@brh28 brh28 deleted the dev/refactor-acct-upgrade branch February 19, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants