feat: Hide header toggle#155
Merged
Merged
Conversation
motorina0
approved these changes
Aug 4, 2025
dni
reviewed
Aug 5, 2025
| delete this.heldCarts[cartId] | ||
| } | ||
| }) | ||
| this.headerElement = document.querySelector('.q-header') |
Member
There was a problem hiding this comment.
couldnt .q-header be used multiple times on the page?
Collaborator
Author
There was a problem hiding this comment.
It's not on tpos, and also, i think, used inside q-layout
dni
reviewed
Aug 5, 2025
dni
reviewed
Aug 5, 2025
| }) | ||
| this.headerElement = document.querySelector('.q-header') | ||
| if (this.headerElement) { | ||
| this.headerElement.style.display = |
Member
There was a problem hiding this comment.
there really should be a variable in the vue component to not render/hide this element.
setting styles on elements like that is hacky.
Collaborator
Author
There was a problem hiding this comment.
The q-header is extended from the base.html, no way to set it in the tpos side.
dni
reviewed
Aug 5, 2025
| }, | ||
| headerToggle() { | ||
| if (this.headerElement) { | ||
| this.headerElement.style.display = |
Member
There was a problem hiding this comment.
don't add inline styles like that, either not render the element, or add/remove classes
Collaborator
Author
There was a problem hiding this comment.
q-header is extended from base.html -> public.html in tpos.html, no way to really hide/show on tpos
Co-authored-by: dni ⚡ <office@dnilabs.com>
dni
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a toggle to show/hide the header
Closes #153