Separate send/receive chaining keys #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShahanaFarooqui
commented
May 12, 2023
ShahanaFarooqui
commented
- Removed max buffer read & write size limit introduced in PR 30.
- Added logic for separate send/receive chaining keys. As troubleshooted and suggested by @rustyrussell.
- Related reference PR 1079.
Closed
lnbc1QWFyb24
approved these changes
May 13, 2023
Owner
lnbc1QWFyb24
left a comment
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Looks good. That's a very subtle but super important bug fix. Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.