Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the connectivity manager as class variable #4

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Store the connectivity manager as class variable #4

merged 2 commits into from
Aug 22, 2022

Conversation

davidoskky
Copy link
Contributor

This fixes #3
It is now possible to stop the monitoring by unregistering the network callback.

ln-12
ln-12 requested changes Aug 22, 2022
View reviewed changes
Copy link
Owner

@ln-12 ln-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Could you please avoid using !!? I think it should be sufficient here to use the ?operator.

@davidoskky
Copy link
Contributor Author

You are right, it is safer this way.

@ln-12 ln-12 merged commit 3a62adb into ln-12:main Aug 22, 2022
@ln-12
Copy link
Owner

ln-12 commented Aug 22, 2022

Looks good to me, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ln-12 ln-12 ln-12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop function does not unregister the network callback in android
2 participants
@davidoskky @ln-12